Refactor to use annotation access pattern #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austindrenski
force-pushed
the
refactor-annotation-patterns
branch
2 times, most recently
from
e78127d to
a9533ca
Compare
YohDeadfall
approved these changes
Nov 21, 2018
roji
requested changes
Nov 22, 2018
Member
roji
left a comment
roji
left a comment
There was a problem hiding this comment.
The overall direction is good and makes the good more clean/idiomatic. But please see notes about where the annotations belong.
austindrenski
force-pushed
the
refactor-annotation-patterns
branch
from
b17fbfd to
e290f96
Compare
austindrenski
force-pushed
the
refactor-annotation-patterns
branch
from
e290f96 to
cbfe6e9
Compare
Contributor
Author
|
@roji I took another pass at this with better naming and more specific extension methods (i.e. not on I think it's a step in the right direction, but may still need some refinement. |
roji
approved these changes
Nov 24, 2018
Member
roji
left a comment
roji
left a comment
There was a problem hiding this comment.
It looks close to ready, see my comment about the interfaces.
For the record I don't think there's huge value in this - it does make for a slightly nicer interface to the annotation data, but lots of code is added to support this...
src/EFCore.PG/Metadata/INpgsqlAlterDatabaseOperationAnnotations.cs
Outdated
Show resolved
Hide resolved
austindrenski
force-pushed
the
refactor-annotation-patterns
branch
from
e21fe78 to
1101084
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized while working on #685 that
PostgresExtension,PostgresEnum, andPostgresRangebroke with (what seems like) the standard annotation access patterns used throughout EF Core.