Remove file license blocks per discussion in 672 #674
Conversation
See: 672#issuecomment-431682630
YohDeadfall
left a comment
YohDeadfall
left a comment
There was a problem hiding this comment.
Looks like some files contains encoding preamble, but others not. Could you fix it?
| @@ -1,6 +1,3 @@ | |||
| // Copyright (c) .NET Foundation. All rights reserved. | |||
| // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | |||
|
|
|||
There was a problem hiding this comment.
Should this header be removed?
There was a problem hiding this comment.
I assumed that was an unintended artifact of some earlier copy/paste, but I guess it could be needed...
@roji Thoughts?
There was a problem hiding this comment.
Yeah, the .NET foundation license headers are a copy-paste mistake (we're not part of the foundation). I say let's remove them all and just leave the LICENSE at the project root...
|
@YohDeadfall wrote:
I'm happy to fix it....but any advice on how to do so without editing each file manually? |
|
Using |
|
At the risk of showing my tenuous familiarity with encodings... It looks like they are all (already) set as This is just a hunch, but I think the files where the BOM was deleted/re-inserted are the files that opened in Rider with their license blocks already collapsed (which I then deleted while collapsed). Perhaps in that case rider deletes (then re-inserts) the preamble? |
|
If no one objects, I'm planning to merge this at 1 PM UTC today. Just post back if you want me to hold off for any reason. |
3 participants
See: #672 (comment)