Skip to content

Conversation

@austindrenski
Copy link
Contributor

@austindrenski austindrenski commented Jul 25, 2018

  • Add doc comments
  • Reorganize methods into regions for Generators and Visitors
  • Make new methods virtual for consistency
  • Add [NotNull] to params on new methods for consistency

@austindrenski austindrenski self-assigned this Jul 25, 2018
@austindrenski austindrenski force-pushed the refactor-sql-generator branch from 0d7ce91 to d9dc68b Compare July 25, 2018 02:44
@austindrenski austindrenski force-pushed the refactor-sql-generator branch 5 times, most recently from 2ca6b57 to 8b3a575 Compare July 25, 2018 04:18
@austindrenski austindrenski force-pushed the refactor-sql-generator branch from 8b3a575 to ae41afc Compare July 25, 2018 04:34
@austindrenski austindrenski changed the title Refactor SQL generator before 541 Refactor SQL generator Jul 25, 2018
@austindrenski austindrenski merged commit 94033c0 into npgsql:dev Jul 25, 2018
@austindrenski austindrenski deleted the refactor-sql-generator branch July 25, 2018 04:54
@roji roji added cleanup and removed refactor labels May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants