Skip to content

Conversation

@naveenpaul1
Copy link
Contributor

@naveenpaul1 naveenpaul1 commented Sep 27, 2024

Explain the changes

  1. tag is added to file/folder xattr from request
  2. file close after open for tagging
  3. Object tag work with slash for folder objects
  4. get last object version specific tag using version id or without.

Issues: Fixed #xxx / Gap #xxx

  1. NSFS | Tagging bugs #8400

Testing Instructions:

  1. please check above issue
  • Doc added/updated
  • Tests added

@shirady
Copy link
Contributor

shirady commented Sep 29, 2024

@naveenpaul1 CopyObject (tagging) is not part of this fix, right?

@naveenpaul1 naveenpaul1 force-pushed the tagging_issue branch 2 times, most recently from 8c61187 to 2060f02 Compare September 30, 2024 05:33
@naveenpaul1
Copy link
Contributor Author

@shirady What I know is copy-object internally uses put-object code for copy. upload_object() method getting called for copy-object request with tag info.
@romayalon correct me if I am wrong.

@naveenpaul1 naveenpaul1 requested a review from shirady September 30, 2024 06:08
Signed-off-by: naveenpaul1 <[email protected]>
@naveenpaul1 naveenpaul1 merged commit 68abc12 into noobaa:master Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants