Skip to content

Conversation

@ykzts
Copy link
Contributor

@ykzts ykzts commented Oct 3, 2016

"About" has been translated into Japanese.

Please review...

to @nodejs/nodejs-ja

@hiroppy hiroppy added i18n Issues/PRs related to the Website Internationalisation needs WG +1 labels Oct 3, 2016
@hiroppy
Copy link
Member

hiroppy commented Oct 3, 2016

cc: @nodejs/nodejs-ja

Copy link
Member

@yosuke-furukawa yosuke-furukawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

各接続ごとにコールバックは発火され、何もすることがない場合は、 Node はスリープします。

ですかね

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この言葉だけでは不慣れな部分がいくつかあるかもしれません、 [Blocking vs Non-Blocking][] にもう少し詳しい記事があります。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Catch!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[`cluster`][] モジュールが

のがいいかと。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

以下の「Hello World」の例では、たくさんの接続を同時に処理することが出来ます。 くらいが、読みやすいかなぁと思いました

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OS の左右にもスペースを入れてもらえますか:bow:

@ykzts
Copy link
Contributor Author

ykzts commented Oct 3, 2016

@yosuke-furukawa @tgfjt thx for review!

updated the commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ブロックングコール

typoだと思うので修正よろしくお願いします。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

失礼、ブロッキングコールですね。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

035893a にて直りました。

@hiroppy
Copy link
Member

hiroppy commented Oct 3, 2016

LGTM 😸

@hiroppy
Copy link
Member

hiroppy commented Oct 3, 2016

マージします:)

@ykzts ty :)

@hiroppy hiroppy merged commit 424eed9 into nodejs:master Oct 3, 2016
@ykzts ykzts deleted the translate/ja-about branch October 3, 2016 08:46
hackygolucky added a commit to hackygolucky/nodejs.org that referenced this pull request Oct 5, 2016
* upstream/master:
  outreachy: add myles' project
  add good first contributions to the outreachy page
  precede email addresses with mailto (nodejs#935)
  Translate "docs" menu as Korean  (nodejs#904)
  nodejs-ja: Add about/index.md (nodejs#933)
  Revert "Blog: fix CVE ID for writeHead() bug / CVE-2016-5326"
  Blog: fix CVE ID for writeHead() bug / CVE-2016-5326
  Add Education initiatives and Outreachy to Foundation section of website (nodejs#929)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Issues/PRs related to the Website Internationalisation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants