-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
nodejs-ja: Add about/index.md #933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc: @nodejs/nodejs-ja |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits.
locale/ja/about/index.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
各接続ごとにコールバックは発火され、何もすることがない場合は、 Node はスリープします。
ですかね
locale/ja/about/index.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
この言葉だけでは不慣れな部分がいくつかあるかもしれません、 [Blocking vs Non-Blocking][] にもう少し詳しい記事があります。
locale/ja/site.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Catch!
locale/ja/about/index.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[`cluster`][] モジュールが
のがいいかと。
locale/ja/about/index.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
以下の「Hello World」の例では、たくさんの接続を同時に処理することが出来ます。 くらいが、読みやすいかなぁと思いました
locale/ja/about/index.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OS の左右にもスペースを入れてもらえますか:bow:
|
@yosuke-furukawa @tgfjt thx for review! updated the commit. |
locale/ja/about/index.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ブロックングコール
typoだと思うので修正よろしくお願いします。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
失礼、ブロッキングコールですね。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
035893a にて直りました。
|
LGTM 😸 |
|
マージします:) @ykzts ty :) |
* upstream/master: outreachy: add myles' project add good first contributions to the outreachy page precede email addresses with mailto (nodejs#935) Translate "docs" menu as Korean (nodejs#904) nodejs-ja: Add about/index.md (nodejs#933) Revert "Blog: fix CVE ID for writeHead() bug / CVE-2016-5326" Blog: fix CVE ID for writeHead() bug / CVE-2016-5326 Add Education initiatives and Outreachy to Foundation section of website (nodejs#929)
"About" has been translated into Japanese.
Please review...
to @nodejs/nodejs-ja