-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat(orama): add defaults #8351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8351 +/- ##
==========================================
- Coverage 76.77% 76.77% -0.01%
==========================================
Files 118 118
Lines 9825 9828 +3
Branches 336 336
==========================================
+ Hits 7543 7545 +2
- Misses 2280 2281 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds default values for three Orama Cloud configuration constants to enable the search functionality to work out-of-the-box without requiring environment variables to be set. Previously, these constants would default to empty strings, preventing the Orama Cloud client from being initialized.
- Added default value for
ORAMA_CLOUD_READ_API_KEY - Added default value for
ORAMA_CLOUD_DATASOURCE_ID - Added default value for
ORAMA_CLOUD_PROJECT_ID
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@nodejs/nodejs-website can we fast track this, it makes local development easier |
Ref: https://openjs-foundation.slack.com/archives/CVAMEJ4UV/p1756145667553889?thread_ts=1755714272.918999&cid=CVAMEJ4UV
All of these variables are public.