Skip to content

Conversation

@avivkeller
Copy link
Member

Copilot AI review requested due to automatic review settings November 12, 2025 01:27
@avivkeller avivkeller requested a review from a team as a code owner November 12, 2025 01:27
@vercel
Copy link

vercel bot commented Nov 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Nov 12, 2025 1:28am

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.77%. Comparing base (c49bc15) to head (659624e).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8351      +/-   ##
==========================================
- Coverage   76.77%   76.77%   -0.01%     
==========================================
  Files         118      118              
  Lines        9825     9828       +3     
  Branches      336      336              
==========================================
+ Hits         7543     7545       +2     
- Misses       2280     2281       +1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copilot finished reviewing on behalf of avivkeller November 12, 2025 01:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds default values for three Orama Cloud configuration constants to enable the search functionality to work out-of-the-box without requiring environment variables to be set. Previously, these constants would default to empty strings, preventing the Orama Cloud client from being initialized.

  • Added default value for ORAMA_CLOUD_READ_API_KEY
  • Added default value for ORAMA_CLOUD_DATASOURCE_ID
  • Added default value for ORAMA_CLOUD_PROJECT_ID

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avivkeller
Copy link
Member Author

@nodejs/nodejs-website can we fast track this, it makes local development easier

@avivkeller avivkeller added the fast-track Fast Tracking PRs label Nov 12, 2025
@avivkeller avivkeller added this pull request to the merge queue Nov 13, 2025
Merged via the queue into main with commit 4c1a417 Nov 13, 2025
22 checks passed
@avivkeller avivkeller deleted the feat-orama-defaults branch November 13, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants