Skip to content

fix: compatibility engine should run even on initial state #7366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 28, 2024
Merged

fix: compatibility engine should run even on initial state #7366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7454dce
fix: compatibility engine should run even on initial state
ovflowd Dec 28, 2024
8d8eddd
chore: aix to be allowed on empty install method
ovflowd Dec 28, 2024
16408a4
chore: update dependency chain
ovflowd Dec 28, 2024
93ab8af
chore: minor effect updates
ovflowd Dec 28, 2024
118982f
fix: layout mobile flex wrap
ovflowd Dec 28, 2024
3ecbaf7
chore: update types to be happy
ovflowd Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/site/components/Downloads/Release/OperatingSystemDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ const OperatingSystemDropdown: FC<OperatingSystemDropdownProps> = () => {
// We parse the compatibility of the dropdown items
const parsedOperatingSystems = useMemo(
() => parseCompat(OPERATING_SYSTEMS, release),
// We only want to react on the change of the OS, Bitness, and Version
// We only want to react on the change of the Install Method
// eslint-disable-next-line react-hooks/exhaustive-deps
[release.os, release.platform, release.version]
[release.installMethod, release.os]
);

return (
Expand Down
2 changes: 1 addition & 1 deletion apps/site/components/Downloads/Release/PackageManagerDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const PackageManagerDropdown: FC = () => {
),
// We only want to react on the change of the Version
// eslint-disable-next-line react-hooks/exhaustive-deps
[release.version]
[release.version, release.packageManager]
);

return (
Expand Down
2 changes: 1 addition & 1 deletion apps/site/components/Downloads/Release/PlatformDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const PlatformDropdown: FC = () => {
: [],
// We only want to react on the change of the OS, Platform, and Version
// eslint-disable-next-line react-hooks/exhaustive-deps
[release.os, release.platform, release.version]
[release.os, release.version]
);

// We set the Platform to the next available Architecture when the current
Expand Down
2 changes: 1 addition & 1 deletion apps/site/components/Downloads/Release/PrebuiltDownloadButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const PrebuiltDownloadButtons: FC = () => {
: '';

return (
<div className="my-4 flex gap-2">
<div className="my-4 flex flex-wrap gap-2">
<Skeleton
loading={os === 'LOADING' || platform === ''}
hide={OS_NOT_SUPPORTING_INSTALLERS.includes(os)}
Expand Down
15 changes: 7 additions & 8 deletions apps/site/util/downloadUtils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ export enum PackageManagerLabel {
}

type DownloadCompatibility = {
os: Array<UserOS>;
installMethod: Array<Types.InstallationMethod>;
platform: Array<UserPlatform>;
os: Array<UserOS | 'LOADING'>;
installMethod: Array<Types.InstallationMethod | ''>;
platform: Array<UserPlatform | ''>;
semver: Array<string>;
releases: Array<NodeReleaseStatus>;
};
Expand Down Expand Up @@ -97,14 +97,13 @@ export const parseCompat = <
): Array<T> => {
const satisfiesSemver = (semver: string) => satisfies(version, semver);

const supportsOS = (i: T['compatibility']) =>
os === 'LOADING' || (i.os?.includes(os) ?? true);
const supportsOS = (i: T['compatibility']) => i.os?.includes(os) ?? true;

const supportsInstallMethod = (i: T['compatibility']) =>
(installMethod === '' || i.installMethod?.includes(installMethod)) ?? true;
i.installMethod?.includes(installMethod) ?? true;

const supportsPlatform = (i: T['compatibility']) =>
platform === '' || (i.platform?.includes(platform) ?? true);
i.platform?.includes(platform) ?? true;

const supportsVersion = (i: T['compatibility']) =>
i.semver?.some(satisfiesSemver) ?? true;
Expand Down Expand Up @@ -145,7 +144,7 @@ export const OPERATING_SYSTEMS: Array<DownloadDropdownItem<UserOS>> = [
{
label: OperatingSystemLabel.AIX,
value: 'AIX',
compatibility: { installMethod: [] },
compatibility: { installMethod: [''] },
iconImage: <OSIcons.AIX width={16} height={16} />,
},
];
Expand Down
Loading