Skip to content

fix: align mdx #7276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2024
Merged

fix: align mdx #7276

merged 1 commit into from
Nov 23, 2024

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Nov 22, 2024

This PR realigns all index.mdx files from all languages. Note that there might be other MDX files with discrepancies too 🤷

@ovflowd ovflowd requested a review from a team as a code owner November 22, 2024 15:06
@vercel Vercel
Copy link

vercel bot commented Nov 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 22, 2024 3:10pm

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@ovflowd ovflowd force-pushed the fix/align-index-mdx branch from fae50cb to 9cd4a93 Compare November 22, 2024 15:09
@ovflowd ovflowd added the fast-track Fast Tracking PRs label Nov 22, 2024
@ovflowd
Copy link
Member Author

ovflowd commented Nov 22, 2024

Requesting fast-tracking! cc @nodejs/nodejs-website

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Nov 22, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 22, 2024 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 97 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@github-actions GitHub Actions
Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
 90.79% (631/695) 72.44% (184/254) 94.53% (121/128)

Unit Test Report

Tests Skipped Failures Errors Time
143 0 💤 0 ❌ 0 🔥 5.541s ⏱️

@bmuenzenmeyer
Copy link
Collaborator

@ovflowd if these were passing lint before, is that indicative that we were not linting/formatting them, or ???

i dont want another crowdin sync to clobber all this, or rather, if the whitespace is unimportant, why fix it

@ovflowd
Copy link
Member Author

ovflowd commented Nov 22, 2024

@ovflowd if these were passing lint before, is that indicative that we were not linting/formatting them, or ???

i dont want another crowdin sync to clobber all this, or rather, if the whitespace is unimportant, why fix it

This has nothing to do with linting. It is a prettier bug. Linting-wise both are valid.

@ovflowd
Copy link
Member Author

ovflowd commented Nov 22, 2024

i dont want another crowdin sync to clobber all this, or rather, if the whitespace is unimportant, why fix it

🤷 -- afaik my changes will override that.

@bmuenzenmeyer
Copy link
Collaborator

interesting, we call prettier directly within https://github.com/nodejs/nodejs.org/blob/main/.github/workflows/translations-pr.yml#L116-L119 instead of using our lint:fix script.

@ovflowd
Copy link
Member Author

ovflowd commented Nov 23, 2024

interesting, we call prettier directly within main/.github/workflows/translations-pr.yml#L116-L119 instead of using our lint:fix script.

Follow-up issue to investigate that?

@ovflowd ovflowd added this pull request to the merge queue Nov 23, 2024
@ovflowd
Copy link
Member Author

ovflowd commented Nov 23, 2024

FYI here's the master issue for MDXv3 for prettier: prettier/prettier#12209

Merged via the queue into main with commit 762362c Nov 23, 2024
23 checks passed
@ovflowd ovflowd deleted the fix/align-index-mdx branch November 23, 2024 01:32
@bmuenzenmeyer bmuenzenmeyer mentioned this pull request Dec 9, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer approved these changes

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Assignees

No one assigned

Labels

fast-track Fast Tracking PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ovflowd @bmuenzenmeyer @AugustinMauroy