Skip to content

fix: footer missing on learn & about layout #6949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmuenzenmeyer merged 1 commit into from
Sep 10, 2024
Merged

fix: footer missing on learn & about layout #6949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/site/layouts/About.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import type { FC, PropsWithChildren } from 'react';

import WithBreadcrumbs from '@/components/withBreadcrumbs';
import WithFooter from '@/components/withFooter';
import WithMetaBar from '@/components/withMetaBar';
import WithNavBar from '@/components/withNavBar';
import WithSidebar from '@/components/withSidebar';
Expand All @@ -21,6 +22,8 @@ const AboutLayout: FC<PropsWithChildren> = ({ children }) => (

<WithBreadcrumbs navKeys={['about', 'getInvolved']} />
</ArticleLayout>

<WithFooter />
</>
);

Expand Down
3 changes: 3 additions & 0 deletions apps/site/layouts/Learn.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import type { FC, PropsWithChildren } from 'react';

import WithBreadcrumbs from '@/components/withBreadcrumbs';
import WithFooter from '@/components/withFooter';
import WithMetaBar from '@/components/withMetaBar';
import WithNavBar from '@/components/withNavBar';
import WithProgressionSidebar from '@/components/withProgressionSidebar';
Expand All @@ -26,6 +27,8 @@ const LearnLayout: FC<PropsWithChildren> = ({ children }) => (

<WithBreadcrumbs navKeys={['learn']} />
</ArticleLayout>

<WithFooter />
</>
);

Expand Down
4 changes: 3 additions & 1 deletion apps/site/layouts/layouts.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
.baseLayout {
@apply grid
size-full
h-max
min-h-full
w-full
grid-cols-[1fr]
grid-rows-[auto_1fr_auto];
}
Expand Down