Skip to content

fix: add page title to <title> tag if possible #5142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
azu wants to merge 1 commit into from
Closed

fix: add page title to <title> tag if possible #5142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion components/HtmlHead.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,15 @@ const HtmlHead = ({ frontMatter }: HeaderProps) => {
const pageTitle = frontMatter.title || siteConfig.title;
const canonicalLink = `https://nodejs.org${route}`;

// "{pageTitle} | {siteConfig.title}" if pageTitle is defined
const title =
// avoid "Node.js | Node.js" title
pageTitle && pageTitle !== siteConfig.title
Copy link
Author

@azu azu Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Some page's ${pageTitle} is "Node.js" and I avoid "Node.js | Node.js".

  • http://localhost:3000/en/: { pageTitle: 'Node.js', siteConfigTitle: 'Node.js' }
  • http://localhost:3000/en/blog/: { pageTitle: 'Node.js', siteConfigTitle: 'Node.js' }

Copy link
Member

@ovflowd ovflowd Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is extra logic. Only the pageTitle should be updated.

? `${pageTitle} | ${siteConfig.title}`
: siteConfig.title;
return (
<Head>
<title>{siteConfig.title}</title>
<title>{title}</title>

<meta name="theme-color" content={siteConfig.accentColor}></meta>

Expand Down