-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
zh-CN,zh-TW: add libera for community support #3943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@nodejs/nodejs-cn @nodejs/nodejs-tw , Plz have a review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Peter Dave Hello <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure every issue mentioned was resolved before requesting another review, because I've noticed there were multiple issues mentioned not only once but not resolved but marked as resolved.
Co-authored-by: Peter Dave Hello <[email protected]>
There's something I want to talk with you:
Not sure how you get this? I'm sure that every problem has been solved before requesting another review, if your suggestion can be accdepted, I'll click "Commit Suggestion". BTW:I find something you've mentioned doesn't make much sense: E.g: "realt-time" can be "实时" and "及时". I hope you DON'T need to pay much attention to these same meanings, if we can understand. I'm not sure whether it's related to your TanWai's dialects or culture language's usage....? |
Considering both Taiwan and the mainland has many diff usages, maybe you can change them in your own way, I have to submit it first |
Consider there're too many diff usages, as well as many tiny usages' diff, merge them first and we can change them one by one
@PeterDaveHello : Then you can change it in your own way, perhaps we have too many diff meanings to express ;) |
As you can see:
Some of the review suggestions were based on the same, not the revised translation, the suggestion diffs were generated by GitHub but not by me, so unless there is something wrong with GitHub or we don't understand the "Commit Suggestion" feature correctly, it looks like some of the suggestions are marked as resolved but actually not.
Sorry that I can't agree with your opinion, which basically would mean that there is no need to translate any Traditional Chinese version any more, as we all can understand most of the Simplified Chinese version. Please not that the Traditional Chinese you're revising is coded "zh-tw" here, so please don't use the terms or usages of Simplified Chinese, but just apply the converted Traditional Chinese character to do the translation, that's very different.
The quality of Google Translation for Traditional Chinese has never been good enough, translation is not just about "you can understand it, that's enough", Google Translation for many scenarios are just using Traditional Chinese character but Simplified Chinese phrase and usages, Bing Microsoft Translator has a different result as you can see: Let's look at a more authoritative resource - the dictionary from Ministry of Education, there is no such term of "實時", even though you converted the character to Traditional Chinese: The term we are using, for zh-tw, Traditional Chinese, is "即時": |
Ref: #3942.