Skip to content

Conversation

SEWeiTung
Copy link
Contributor

Ref: #3942.

@SEWeiTung
Copy link
Contributor Author

@nodejs/nodejs-cn @nodejs/nodejs-tw , Plz have a review. Thanks!

Copy link
Contributor

@willin willin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SEWeiTung SEWeiTung requested a review from PeterDaveHello July 3, 2021 00:12
Copy link
Member

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure every issue mentioned was resolved before requesting another review, because I've noticed there were multiple issues mentioned not only once but not resolved but marked as resolved.

@SEWeiTung
Copy link
Contributor Author

SEWeiTung commented Jul 4, 2021

@PeterDaveHello

There's something I want to talk with you:

Please make sure every issue mentioned was resolved before requesting another review, because I've noticed there were multiple issues mentioned not only once but not resolved but marked as resolved.

Not sure how you get this? I'm sure that every problem has been solved before requesting another review, if your suggestion can be accdepted, I'll click "Commit Suggestion".

BTW:I find something you've mentioned doesn't make much sense:

E.g: "realt-time" can be "实时" and "及时". I hope you DON'T need to pay much attention to these same meanings, if we can understand. I'm not sure whether it's related to your TanWai's dialects or culture language's usage....?

This is from Baidu:
image

From Google, both can be right:
image

@SEWeiTung SEWeiTung requested a review from PeterDaveHello July 4, 2021 00:51
@SEWeiTung
Copy link
Contributor Author

Considering both Taiwan and the mainland has many diff usages, maybe you can change them in your own way, I have to submit it first

@SEWeiTung SEWeiTung dismissed PeterDaveHello’s stale review July 4, 2021 01:07

Consider there're too many diff usages, as well as many tiny usages' diff, merge them first and we can change them one by one

@SEWeiTung SEWeiTung merged commit 23b9183 into nodejs:master Jul 4, 2021
@SEWeiTung SEWeiTung deleted the newtrans branch July 4, 2021 01:08
@SEWeiTung
Copy link
Contributor Author

@PeterDaveHello : Then you can change it in your own way, perhaps we have too many diff meanings to express ;)

@SEWeiTung SEWeiTung removed the request for review from PeterDaveHello July 4, 2021 01:10
@PeterDaveHello
Copy link
Member

@PeterDaveHello

There's something I want to talk with you:

Please make sure every issue mentioned was resolved before requesting another review, because I've noticed there were multiple issues mentioned not only once but not resolved but marked as resolved.

Not sure how you get this? I'm sure that every problem has been solved before requesting another review, if your suggestion can be accdepted, I'll click "Commit Suggestion".

As you can see:

Some of the review suggestions were based on the same, not the revised translation, the suggestion diffs were generated by GitHub but not by me, so unless there is something wrong with GitHub or we don't understand the "Commit Suggestion" feature correctly, it looks like some of the suggestions are marked as resolved but actually not.

BTW:I find something you've mentioned doesn't make much sense:

E.g: "realt-time" can be "实时" and "及时". I hope you DON'T need to pay much attention to these same meanings, if we can understand. I'm not sure whether it's related to your TanWai's dialects or culture language's usage....?

Sorry that I can't agree with your opinion, which basically would mean that there is no need to translate any Traditional Chinese version any more, as we all can understand most of the Simplified Chinese version.

Please not that the Traditional Chinese you're revising is coded "zh-tw" here, so please don't use the terms or usages of Simplified Chinese, but just apply the converted Traditional Chinese character to do the translation, that's very different.

This is from Baidu:
image

From Google, both can be right:

The quality of Google Translation for Traditional Chinese has never been good enough, translation is not just about "you can understand it, that's enough", Google Translation for many scenarios are just using Traditional Chinese character but Simplified Chinese phrase and usages, Bing Microsoft Translator has a different result as you can see:

image

Let's look at a more authoritative resource - the dictionary from Ministry of Education, there is no such term of "實時", even though you converted the character to Traditional Chinese:
image

The term we are using, for zh-tw, Traditional Chinese, is "即時":
http://dict.revised.moe.edu.tw/cgi-bin/cbdic/gsweb.cgi?o=dcbdic&searchid=Z00000088018
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants