-
-
Couldn't load subscription status.
- Fork 6.4k
Update handlebars to version 4.0.3 🚀 #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This update has to be tested, handling of contexts changed between Handlebars v3 and v4 (this could break some stuff). |
|
I believe the test coverage might not be enough. Handlebars v3 and v4 are quite different. |
|
@stevemao We only test (parts) of our scripts at the moment, we don't have any integration/visual regression tests at all. That's why I wrote the comment. |
|
I can see that. I think it is a bit hard to merge this. The time we spend on testing this manually might be the same as adding the tests. |
|
@nodejs/website To make sure the handlebars update doesn't break anything, I did a full build with v3.0.3 and diffed it to a build with 4.0.3 – luckily there were only three tiny changes necessary, so everything should be fine. |
|
Ignore the failing test on Travis, |
|
Nicely tested @fhemberger 👍 |
Update handlebars to version 4.0.3 🚀
Hello 👋
🚀🚀🚀
handlebars just published its new version 4.0.3, which is not covered by your current version range.
If this pull request passes your tests you can publish your software with the latest version of handlebars – otherwise use this branch to work on adaptions and fixes.
Happy fixing and merging 🌴
The new version differs by 118 commits .
9365b82v4.0.3bf09177Update release notes94c840bCreate data frame for @partial-block861d6f7Fix tests under IEfffb5a9Fix iteration over undefined values0878179Allow for escaped ] characters in [] IDs641fe33Update travis to test node 0.12 and 4.0.0733b7c8Merge pull request #1091 from nikolas/patch-29a86e40Merge pull request #1090 from nikolas/patch-1efad390fix typo in release notes3696d23grammar fixes in 4.0.0 release notesa5a3ab0v4.0.2c833541Update release notes7b1fdf8Fix use of decorators within partialsc7b28a6v4.0.1There are 118 commits in total. See the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? Upgrade to the supporter plan! You'll also get your pull requests faster ⚡It keeps your software, up to date, all the time.