-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Closed
Description
It seems httmllint gets confused by the missing space in the handlebar templates, but this issue only appears on Windows hence why Travis CI builds just pass.
C:\Users\xmr\Desktop\nodejs.org>npm t
> nodejs.org@ test C:\Users\xmr\Desktop\nodejs.org
> npm run test:lint && npm run test:unit && npm run test:smoke
> nodejs.org@ test:lint C:\Users\xmr\Desktop\nodejs.org
> standard --fix && htmllint **/*.hbs && stylint layouts/css && markdownlint "**/*.md" -i "node_modules/"
layouts/partials/footer.hbs: line 3, col 20, value must match the format: dash
layouts/partials/footer.hbs: line 3, col 1, tag is not closed
layouts/partials/header.hbs: line 10, col 9, tag is not closed
layouts/partials/navigation.hbs: line 6, col 11, tag is not closed
I don't think we should change the code to add the space back. In fact I'm not sure if htmllint offers any value... The website was full of serious HTML validation errors that were caught by the official HTML validator which I plan to add here eventually.
Let me know how to proceed.
Metadata
Metadata
Assignees
Labels
No labels