-
-
Notifications
You must be signed in to change notification settings - Fork 34k
doc: update Diag WG info #9329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update Diag WG info #9329
Conversation
WORKING_GROUPS.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*with VMs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it's to integrate these with Node itself, such as updating the built-in debugger and updating docs for inspector, or collaborating on #9304.
Will update text accordingly.
WORKING_GROUPS.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this falls under the core collaborators rather than this specific group?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far implementing async_wrap has been monitored by the Diagnostic WG. We have maintained the unofficial documentation, issue lists and I/Trevor provides monthly status updates. We also have quite a few APM members, who provides us with usecase information though the WG meetings and issues.
I don't know if maintaining is a part of this, but improving definitely does. Once async_hooks lands we may want to revisit that.
|
I think we should update the wording on some things |
WORKING_GROUPS.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node.js
WORKING_GROUPS.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node.js
WORKING_GROUPS.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node.js
|
Updated, @Fishrock123 @AndreasMadsen PTAL. Thanks! |
|
LGTM |
Updates info on Diagnostics WG (https://github.com/nodejs/diagnostics). PR-URL: nodejs#9329 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 1f08d35. Thanks! |
Updates info on Diagnostics WG (https://github.com/nodejs/diagnostics). PR-URL: #9329 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Updates info on Diagnostics WG (https://github.com/nodejs/diagnostics). PR-URL: #9329 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Updates info on Diagnostics WG (https://github.com/nodejs/diagnostics). PR-URL: #9329 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Checklist
Affected core subsystem(s)
doc
Description of change
Updates info on Diagnostics WG (https://github.com/nodejs/diagnostics).
Fixes nodejs/diagnostics#69
/cc @nodejs/diagnostics