test-debugger-pid: Somes fixes that do not change performance #9011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Oct 10, 2016
|
LGTM if CI is good. (Nit: commit message should conform to the CONTRIBUTING.md guidelines. Not a big deal, though, can be fixed by whoever lands the change.) |
larissayvette
force-pushed
the
fix-branch
branch
from
d6e4496 to
69e1969
Compare
|
@Trott, changes made. I have succeeded in complying the commit message as required |
|
CI: https://ci.nodejs.org/job/node-test-pull-request/4464/ Nit: subsystem on commit message should be |
larissayvette
force-pushed
the
fix-branch
branch
from
69e1969 to
823f975
Compare
gibfahn
approved these changes
Oct 12, 2016
|
Looks like CI was entirely green? @Trott You must have a magic touch. LGTM |
jasnell
pushed a commit
that referenced
this pull request
Oct 12, 2016
PR-URL: #9011 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Landed in 1bc9af8. Thank you @larissayvette! |
jasnell
pushed a commit
that referenced
this pull request
Oct 12, 2016
PR-URL: #9011 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 11, 2016
PR-URL: #9011 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected core subsystem(s)
test/test-debugger-pid.js
Description of change
Changes that do not affect how the system functions