Skip to content

test: modernize JS and tighten equality checking #8476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

test: modernize JS and tighten equality checking #8476

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf268be
test: modernize JS and tighten equality checking
pogilvie Sep 10, 2016
57681c4
use template literal
pogilvie Sep 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions test/parallel/test-net-binary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
/* eslint-disable strict */
require('../common');
var assert = require('assert');
var net = require('net');
const assert = require('assert');
const net = require('net');

var binaryString = '';
for (var i = 255; i >= 0; i--) {
var s = '\'\\' + i.toString(8) + '\'';
var S = eval(s);
assert.ok(S.charCodeAt(0) == i);
assert.ok(S == String.fromCharCode(i));
const s = `'\\${i.toString(8)}'`;
const S = eval(s);
assert.strictEqual(S.charCodeAt(0), i);
assert.strictEqual(S, String.fromCharCode(i));
binaryString += S;
}

Expand All @@ -28,13 +28,13 @@ var recv = '';

echoServer.on('listening', function() {
var j = 0;
var c = net.createConnection({
const c = net.createConnection({
port: this.address().port
});

c.setEncoding('latin1');
c.on('data', function(chunk) {
var n = j + chunk.length;
const n = j + chunk.length;
while (j < n && j < 256) {
c.write(String.fromCharCode(j), 'latin1');
j++;
Expand All @@ -57,11 +57,11 @@ echoServer.on('listening', function() {
process.on('exit', function() {
assert.equal(2 * 256, recv.length);

var a = recv.split('');
const a = recv.split('');

var first = a.slice(0, 256).reverse().join('');
const first = a.slice(0, 256).reverse().join('');

var second = a.slice(256, 2 * 256).join('');
const second = a.slice(256, 2 * 256).join('');

assert.equal(first, second);
assert.strictEqual(first, second);
});