Skip to content

Conversation

joshgav
Copy link
Contributor

@joshgav joshgav commented Sep 6, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

/cc @nodejs/ctc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 6, 2016
@jasnell
Copy link
Member

jasnell commented Sep 6, 2016

LGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Dickinson.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed. LGTY?

@Trott
Copy link
Member

Trott commented Sep 7, 2016

LGTM

PR-URL: nodejs#8424
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@joshgav joshgav merged commit f1629e7 into nodejs:master Sep 12, 2016
@joshgav
Copy link
Contributor Author

joshgav commented Sep 12, 2016

landed in f1629e7

Fishrock123 pushed a commit that referenced this pull request Sep 14, 2016
PR-URL: #8424
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
PR-URL: #8424
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
PR-URL: #8424
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
PR-URL: #8424
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
PR-URL: #8424
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
@joshgav joshgav deleted the ctc-2016-08-31 branch October 27, 2016 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants