Skip to content

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Aug 30, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Another round of AUTHORS.md updates. This is an initial take. The list needs to be cleaned with duplicates removed and real names added. Help is appreciated! :-) /cc @nodejs/collaborators

Note: All of the edits on this were generated automatically by the update-authors tool. It's quite likely that there are incorrect edits.

@jasnell jasnell added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Aug 30, 2016
AUTHORS Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this done on a purpose?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope... the update-authors tool changed a bunch of these. I'm changing them back

@rumkin
Copy link
Contributor

rumkin commented Sep 1, 2016

@jasnell Rumkin is ok.

@jasnell
Copy link
Member Author

jasnell commented Sep 2, 2016

Ok, @nodejs/collaborators ... I think this is ready to go. PTAL

AUTHORS Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay, I’m duplicate! 😄 (this one is the one which should be removed)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha! I thought I caught all of those. thanks! :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@addaleax
Copy link
Member

addaleax commented Sep 2, 2016

LGTM! :)

@silverwind
Copy link
Contributor

silverwind commented Sep 2, 2016

@jasnell why not edit .mailmap so you don't have to do the same manual changes the next time?

@jasnell
Copy link
Member Author

jasnell commented Sep 2, 2016

heh... that would make far too much sense ;-) ... good idea!

@jasnell
Copy link
Member Author

jasnell commented Sep 2, 2016

@ChALkeR ... does this LGTY?
@nodejs/collaborators ... anyone else?

@MylesBorins
Copy link
Contributor

LGTM

1 similar comment
@silverwind
Copy link
Contributor

LGTM

AUTHORS Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be probably kept as it was, ref: #6373 (comment)

It's that time again! Another round of author list updates.
@jasnell
Copy link
Member Author

jasnell commented Sep 4, 2016

@ChALkeR ... updated!

@saadq
Copy link
Contributor

saadq commented Sep 4, 2016

Thanks for the edit, looks good.

@danbev
Copy link
Contributor

danbev commented Sep 4, 2016

LGTM

jasnell added a commit that referenced this pull request Sep 4, 2016
It's that time again! Another round of author list updates.

PR-URL: #8346
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Sep 4, 2016

Landed in dfe1c7e. Thanks all!

@jasnell jasnell closed this Sep 4, 2016
@Fishrock123 Fishrock123 mentioned this pull request Sep 6, 2016
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 8, 2016
It's that time again! Another round of author list updates.

PR-URL: nodejs#8346
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Sep 9, 2016
It's that time again! Another round of author list updates.

PR-URL: #8346
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
It's that time again! Another round of author list updates.

PR-URL: #8346
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
It's that time again! Another round of author list updates.

PR-URL: #8346
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
It's that time again! Another round of author list updates.

PR-URL: #8346
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
It's that time again! Another round of author list updates.

PR-URL: #8346
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.