Skip to content

Conversation

Alexis374
Copy link
Contributor

@Alexis374 Alexis374 commented Aug 29, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md

fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 29, 2016
@addaleax
Copy link
Member

Looks good to me!

Could you amend the commit message so that it starts with doc:, though?

@Alexis374 Alexis374 changed the title add .md to the link doc: add .md to the link Aug 29, 2016
@Fishrock123
Copy link
Contributor

@Alexis374 Looks like you only changed the PR title, not the actual commit.

To amend the commit message, you'll need a local clone of your github fork on node.

Then:

git checkout origin/patch-1
git commit --amend (will bring up an editor such as vim)
git push origin head --force

@jasnell
Copy link
Member

jasnell commented Aug 29, 2016

LGTM with the commit log fix.

@Alexis374
Copy link
Contributor Author

@addaleax @Fishrock123 I did as you told, please check whether I did sth wrong.

@addaleax
Copy link
Member

@Alexis374 it looks like there’s a git merge (or git pull) that got mixed up in your PR… something along the lines of git rebase -i master, then removing all lines except for the doc: fix a wrong link,add '.md' to the link one and then force-pushing again using git push -f would probably work.

(nobody is claiming that git is easy to work with… :/)

addaleax pushed a commit that referenced this pull request Sep 2, 2016
fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md

PR-URL: #8315
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax
Copy link
Member

addaleax commented Sep 2, 2016

I’ve landed 297d4e4 in 5930d59, thanks for the contribution!

@addaleax addaleax closed this Sep 2, 2016
@Fishrock123 Fishrock123 mentioned this pull request Sep 6, 2016
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 8, 2016
fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md

PR-URL: nodejs#8315
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Sep 9, 2016
fix a wrong link to ../topics/the-event-loop-timers-and-nexttick.md

PR-URL: #8315
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants