Skip to content

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Aug 3, 2016

I am not sure there’s a fixed process for this (or if so, I couldn’t find it/tell from the previous CTC changes), so… I guess here I am?

Voted on and approved at CTC meeting
nodejs#7948
(2016-08-03).
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 3, 2016
@evanlucas
Copy link
Contributor

LGTM

1 similar comment
@cjihrig
Copy link
Contributor

cjihrig commented Aug 3, 2016

LGTM

@bnoordhuis
Copy link
Member

There goes my top spot... LGTM. Welcome, Anna.

@jasnell
Copy link
Member

jasnell commented Aug 3, 2016

LGTM!!

@jasnell
Copy link
Member

jasnell commented Aug 3, 2016

I'm gonna go out on a limb and say this one doesn't need to wait 48/72 hours to land. The CTC approved the nomination today and @addaleax is now a CTC member. Woot!

jasnell pushed a commit that referenced this pull request Aug 3, 2016
Voted on and approved at CTC meeting
#7948
(2016-08-03).

PR-URL: #7966
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax
Copy link
Member Author

addaleax commented Aug 3, 2016

@jasnell … was just about to merge this myself ;)
Did you mean to close this? Anyway, landed in 0c73685!

@addaleax addaleax closed this Aug 3, 2016
@addaleax addaleax deleted the addaleax-ctc branch August 3, 2016 22:38
@jasnell
Copy link
Member

jasnell commented Aug 3, 2016

Yes! I just hadn't gotten back to the UI to do so :-D

@cjihrig cjihrig mentioned this pull request Aug 8, 2016
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
Voted on and approved at CTC meeting
#7948
(2016-08-03).

PR-URL: #7966
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@cjihrig cjihrig mentioned this pull request Aug 11, 2016
MylesBorins pushed a commit that referenced this pull request Sep 9, 2016
Voted on and approved at CTC meeting
#7948
(2016-08-03).

PR-URL: #7966
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
Voted on and approved at CTC meeting
#7948
(2016-08-03).

PR-URL: #7966
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Voted on and approved at CTC meeting
#7948
(2016-08-03).

PR-URL: #7966
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Voted on and approved at CTC meeting
#7948
(2016-08-03).

PR-URL: #7966
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants