Skip to content

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 26, 2016

Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

An apostrophe was being used where a backtick was called for, resulting
in improper rendering.

An apostrophe was being used where a backtick was called for, resulting
in improper rendering.
@Trott Trott added the doc Issues and PRs related to the documentations. label Jun 26, 2016
@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Jun 26, 2016
@addaleax
Copy link
Member

LGTM

1 similar comment
@mscdex
Copy link
Contributor

mscdex commented Jun 26, 2016

LGTM

@RReverser
Copy link
Member

LGTM.

@cjihrig
Copy link
Contributor

cjihrig commented Jun 27, 2016

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Jun 27, 2016

LGTM

jasnell pushed a commit that referenced this pull request Jun 27, 2016
An apostrophe was being used where a backtick was called for, resulting
in improper rendering.

PR-URL: #7431
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Ingvar Stepanyan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jun 27, 2016

Landed in 4220e86

@jasnell jasnell closed this Jun 27, 2016
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
An apostrophe was being used where a backtick was called for, resulting
in improper rendering.

PR-URL: #7431
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Ingvar Stepanyan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
@Trott Trott deleted the graphic branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants