Skip to content

Conversation

Fishrock123
Copy link
Contributor

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc, meta

Description of change
  • Templates are now a bit more consistent with phrasing.
  • Simplified a bit.

cc @Trott etc

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 24, 2016
@Fishrock123 Fishrock123 added the doc Issues and PRs related to the documentations. label Jun 24, 2016
@claudiorodriguez
Copy link
Contributor

LGTM

3 similar comments
@Trott
Copy link
Member

Trott commented Jun 24, 2016

LGTM

@JungMinu
Copy link
Member

LGTM

@targos
Copy link
Member

targos commented Jun 26, 2016

LGTM

- Templates are now a bit more consistent with phrasing.
- Simplified a bit.

PR-URL: nodejs#7403
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@Fishrock123 Fishrock123 merged commit 1db31a3 into nodejs:master Jun 27, 2016
@Fishrock123 Fishrock123 deleted the github-templates branch June 27, 2016 07:54
Fishrock123 added a commit that referenced this pull request Jun 27, 2016
- Templates are now a bit more consistent with phrasing.
- Simplified a bit.

PR-URL: #7403
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Jun 27, 2016
Fishrock123 added a commit that referenced this pull request Jul 5, 2016
- Templates are now a bit more consistent with phrasing.
- Simplified a bit.

PR-URL: #7403
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants