test: add note about duration_ms in TAP reporter #7216
Conversation
This reverts commit d413378.
|
@rvagg I think you accidentally included some unrelated (http) changes in your commit. |
mscdex
added
test
|
@rvagg Thanks for picking up on this! I couldn't find any documentation about it anywhere (e.g. on the TAP website) but I can see that the Jenkins TAP parser understands duration_ms so I guess there's no alternative. |
|
I really should have documented this earlier @gibm, I went though this exact pain very early on because it frustrated me too. I ended up in the Jenkins source code just to verify that it relied on it in this form. I think it's just one of those standards that have appeared and been widely enough adopted to be stuck in a semi-official state. |
|
LGTM |
|
LGTM |
|
LGTM |
|
LOOKS GOOD TO ME |
|
@rvagg Looks like there's a PR that will go into a future version of the TAP plugin which requires Not sure how we'd deal with this. EDIT: It might be worth adding a |
|
oh my, that's terrible, I've added a comment over there |
This reverts commit d413378. PR-URL: #7216 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
PR-URL: #7216 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
This reverts commit d413378. PR-URL: #7216 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
PR-URL: #7216 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
9 participants
Following on from #7214 (including that commit), adds an inline comment for future reference