build: update rpmbuild .spec file #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
There was a problem hiding this comment.
Is "io.js" lowercased even if it starts a sentence?
There was a problem hiding this comment.
In this case we should note it somewhere like npm guys did. Maybe in readme.
Rename the package to iojs. No Conflicts: header is necessary because the package was already marked as conflicting with the Fedora nodejs package. PR-URL: nodejs#71 Reviewed-By: Rod Vagg <[email protected]>
Rename the .spec file from node.spec to iojs.spec and update the build script. Done as a separate commit to not obscure the changes from the previous commit. PR-URL: nodejs#71 Reviewed-By: Rod Vagg <[email protected]>
bnoordhuis
force-pushed
the
rename-spec-file
branch
from
b4c6c19 to
993fadb
Compare
bnoordhuis
pushed a commit
that referenced
this pull request
Dec 5, 2014
Fixes nodejs/node-v0.x-archive#8237. PR-URL: #71 Reviewed-By: Ben Noordhuis <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the package to iojs. No Conflicts: header is necessary because
the package was already marked as conflicting with the Fedora nodejs
package.
R=@rvagg, possibly useful for nodejs/build#18.