Skip to content

Conversation

bengl
Copy link
Member

@bengl bengl commented Apr 12, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Clarify in docs for require.cache that reloading native modules
isn't supported.

Close this if #6165 lands instead.

Related: #6160

Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: nodejs#6160
@benjamingr
Copy link
Member

LGTM

@benjamingr benjamingr added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Apr 12, 2016
@mscdex
Copy link
Contributor

mscdex commented Apr 12, 2016

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Apr 18, 2016

LGTM

jasnell pushed a commit that referenced this pull request Apr 18, 2016
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: #6160
PR-URL: #6168
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Apr 18, 2016

Landed in 5c14d69

@jasnell jasnell closed this Apr 18, 2016
MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: #6160
PR-URL: #6168
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: #6160
PR-URL: #6168
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: #6160
PR-URL: #6168
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 20, 2016
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: #6160
PR-URL: #6168
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Apr 21, 2016
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: #6160
PR-URL: #6168
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: nodejs#6160
PR-URL: nodejs#6168
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: #6160
PR-URL: #6168
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 3, 2016
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: #6160
PR-URL: #6168
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 6, 2016
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: #6160
PR-URL: #6168
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
Clarify in docs for require.cache that reloading native modules
isn't supported.

Related: #6160
PR-URL: #6168
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants