Skip to content

Conversation

avivkeller
Copy link
Member

cc @0hmX to confirm that this is correct.

#58748 added a new method, createTagStore, but it's improperly documented as createSQLTagStore

Ref: https://discord.com/channels/425824580918181889/425824580918181891/1425966053242048584

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. sqlite Issues and PRs related to the SQLite subsystem. labels Oct 9, 2025
@0hmX
Copy link
Contributor

0hmX commented Oct 10, 2025

Yes that is true, it's wrongly documented. Thanks for the fix 🙌

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 11, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2025
@nodejs-github-bot nodejs-github-bot merged commit d54e6ae into nodejs:main Oct 11, 2025
31 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d54e6ae

@avivkeller avivkeller deleted the patch-213461 branch October 11, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants