Skip to content

doc: update teams in collaborator-guide.md and add links #60065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 11, 2025
Merged

doc: update teams in collaborator-guide.md and add links #60065

merged 6 commits into from
Oct 11, 2025

Conversation

louwers
Copy link
Contributor

@louwers louwers commented Sep 28, 2025 •
edited
Loading

  • Remove @nodejs/modules, team does not exist
  • Remove @nodejs/util
  • Add @nodejs/sqlite
  • Add links

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 28, 2025
@aduh95
Copy link
Contributor

aduh95 commented Oct 7, 2025

Those links makes the document very hard to read, if we're adding them (and tbh, I'm not sure it's worth it), we would want to add references at the end of the file (i.e. [@nodejs/team][] in the table and [@nodejs/team]: https://… at EOF)

@louwers
Copy link
Contributor Author

louwers commented Oct 7, 2025

@aduh95 Good call!

@louwers
Copy link
Contributor Author

louwers commented Oct 7, 2025

@aduh95 Please have another look, thanks!

aduh95
aduh95 reviewed Oct 7, 2025
View reviewed changes
@louwers
Copy link
Contributor Author

louwers commented Oct 8, 2025

cc @bnoordhuis @indutny @mscdex @rvagg removing your names from the collaborator guide, please join a team instead if you want to be pinged.

@louwers louwers requested review from aduh95 and rvagg October 8, 2025 11:01
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 11, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2025
@nodejs-github-bot nodejs-github-bot merged commit a2f088d into nodejs:main Oct 11, 2025
26 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a2f088d

@RafaelGSS RafaelGSS mentioned this pull request Oct 13, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@aduh95 aduh95 aduh95 approved these changes

@rvagg rvagg Awaiting requested review from rvagg

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@louwers @nodejs-github-bot @aduh95 @rvagg @lpinca