Skip to content

wasm: enable JSPI #59941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

wasm: enable JSPI #59941

wants to merge 1 commit into from

Conversation

guybedford
Copy link
Contributor

This enables the WebAssembly JS Promise Integration Stage 4 WebAssembly proposal which is currently shipped in Chrome.

A new Wasm test is also included to verify that it works correctly.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 20, 2025
jasnell
jasnell approved these changes Sep 20, 2025
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but the test could use a comment that explains the expectations a bit as most folks aren't familiar with jspi yet and won't have much context.

@richardlau richardlau added semver-minor PRs that contain new features and should be released in the next minor version. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Sep 20, 2025
@codecov Codecov
Copy link

codecov bot commented Sep 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.44%. Comparing base (4612c79) to head (e2d1d28).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59941      +/-   ##
==========================================
+ Coverage   88.25%   88.44%   +0.19%     
==========================================
  Files         703      703              
  Lines      207412   207402      -10     
  Branches    39893    39991      +98     
==========================================
+ Hits       183052   183445     +393     
+ Misses      16313    15930     -383     
+ Partials     8047     8027      -20
Files with missing lines Coverage Δ
src/node.cc 75.80% <100.00%> (+0.03%) ⬆️

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@guybedford
Copy link
Contributor Author

Sure, I've added some more documentation to the test.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69304/

guybedford added a commit that referenced this pull request Sep 23, 2025
@guybedford
wasm: enable JSPI
4396cf2 
PR-URL: #59941
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@guybedford
Copy link
Contributor Author

Landed in 4396cf2.

@guybedford guybedford closed this Sep 23, 2025
@guybedford guybedford deleted the jspi branch September 23, 2025 01:13
@guybedford guybedford mentioned this pull request Sep 25, 2025
Closed
@RafaelGSS RafaelGSS mentioned this pull request Oct 13, 2025
Merged
9 tasks
@terrablue terrablue mentioned this pull request Oct 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@guybedford @nodejs-github-bot @jasnell @lpinca @anonrig @richardlau