Skip to content

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Sep 11, 2025

Fixes a regression introduced at #57672 where suite timeout option never takes effect

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 11, 2025
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (0fb0406) to head (a405bba).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59853      +/-   ##
==========================================
- Coverage   88.55%   88.53%   -0.02%     
==========================================
  Files         704      704              
  Lines      208089   208091       +2     
  Branches    40017    40018       +1     
==========================================
- Hits       184270   184233      -37     
- Misses      15818    15865      +47     
+ Partials     8001     7993       -8     
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 97.36% <100.00%> (+<0.01%) ⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there are related test failures :)

@MoLow MoLow force-pushed the fix-suite-timeout branch 2 times, most recently from 04fe203 to 99f6289 Compare October 8, 2025 09:04
@MoLow MoLow force-pushed the fix-suite-timeout branch from 99f6289 to a405bba Compare October 8, 2025 10:27
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2025
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Oct 8, 2025
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Failed to start CI
   ⚠  Commits were pushed since the last approving review:
   ⚠  - test_runner: fix suite timeout
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/18343105598

@MoLow MoLow added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Oct 8, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2025
@nodejs-github-bot nodejs-github-bot merged commit 6dbf708 into nodejs:main Oct 9, 2025
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6dbf708

@MoLow MoLow deleted the fix-suite-timeout branch October 9, 2025 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants