deps: update V8 to 14.1

[targos]

This should replace #58491

Still blocked at least on nodejs/build#4083

V8 CI is also broken because --always-turbofan flag was removed. I tried to fix it in canary with ab7d369, but then test/v8-updates/test-linux-perf-logger.js fails because the functions don't get optimized: https://ci.nodejs.org/job/node-test-commit-v8-linux/6742/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/console

Notable changes since 13.7:

• JSON.stringify performance improvements
• Uint8Array to/from base64 and hex

[nodejs-github-bot]

Review requested:

• @nodejs/gyp
• @nodejs/security-wg
• @nodejs/v8-update

[targos]

@nodejs/cpp-reviewers Please take a look at 1bf9e85 and a540d99.

[targos]

/cc @lukealbao In case you have ideas on how to adapt test-linux-perf-logger.

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6747/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6747/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6747/

[targos]

@nodejs/platform-ppc @nodejs/platform-s390 we quickly get a compiler error:

14:43:02 FAILED: obj/v8_bigint/mul-karatsuba.o 
14:43:02 ccache g++ -MD -MF obj/v8_bigint/mul-karatsuba.o.d -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_NONE -D_GLIBCXX_ASSERTIONS=1 -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_OZONE=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64 -DENABLE_GDB_JIT_INTERFACE -DV8_INTL_SUPPORT -DV8_USE_EXTERNAL_STARTUP_DATA -DV8_ATOMIC_OBJECT_FIELD_WRITES -DV8_ENABLE_LAZY_SOURCE_POSITIONS -DV8_WIN64_UNWINDING_INFO -DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH -DV8_ENABLE_SPARKPLUG -DV8_ENABLE_TURBOFAN -DV8_ENABLE_WEBASSEMBLY -DV8_ENABLE_CONTINUATION_PRESERVED_EMBEDDER_DATA -DV8_ALLOCATION_FOLDING -DV8_ALLOCATION_SITE_TRACKING -DV8_ADVANCED_BIGINT_ALGORITHMS -DV8_USE_ZLIB -DV8_ENABLE_MAGLEV_GRAPH_PRINTER -DV8_ENABLE_EXTENSIBLE_RO_SNAPSHOT -DV8_ENABLE_BLACK_ALLOCATED_PAGES -DV8_ENABLE_LEAPTIERING -DV8_WASM_RANDOM_FUZZERS -DV8_ARRAY_BUFFER_INTERNAL_FIELD_COUNT=0 -DV8_ARRAY_BUFFER_VIEW_INTERNAL_FIELD_COUNT=0 -DV8_PROMISE_INTERNAL_FIELD_COUNT=0 -DV8_USE_DEFAULT_HASHER_SECRET=true -DV8_DEPRECATION_WARNINGS -DV8_IMMINENT_DEPRECATION_WARNINGS -DV8_HAVE_TARGET_OS -DV8_TARGET_OS_LINUX -DCPPGC_ENABLE_LARGER_CAGE -DCPPGC_SLIM_WRITE_BARRIER -DV8_TARGET_ARCH_PPC64 -I../.. -Igen -I../../include -Igen/include -Wall -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-deprecated-declarations -Wno-comments -Wno-packed-not-aligned -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Werror -fno-strict-overflow -fno-ident -fno-math-errno -fno-strict-aliasing -fstack-protector -funwind-tables -fPIC -pipe -pthread -m64 -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fno-omit-frame-pointer -g0 -ffp-contract=off -Wno-invalid-offsetof -Wno-strict-overflow -Wno-return-type -Wno-int-in-bool-context -Wno-deprecated -Wno-stringop-overflow -Wno-stringop-overread -Wno-restrict -Wno-array-bounds -Wno-nonnull -Wno-dangling-pointer -O3 -fdata-sections -ffunction-sections -fvisibility=default -Wno-narrowing -Wno-class-memaccess -Wno-invalid-offsetof -std=gnu++2a -fno-exceptions -fno-rtti  -c ../../src/bigint/mul-karatsuba.cc -o obj/v8_bigint/mul-karatsuba.o
14:43:02 ../../src/bigint/mul-karatsuba.cc: In function ‘uint32_t v8::bigint::{anonymous}::RoundUpLen(uint32_t)’:
14:43:02 ../../src/bigint/mul-karatsuba.cc:51:38: error: comparison of integer expressions of different signedness: ‘uint32_t’ {aka ‘unsigned int’} and ‘int’ [-Werror=sign-compare]
14:43:02    51 |   if (shift >= 2 && (len & additive) < (1 << (shift - 2))) {
14:43:02       |                     ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
14:43:02 cc1plus: all warnings being treated as errors

[richardlau]

@nodejs/platform-ppc @nodejs/platform-s390 we quickly get a compiler error:

This might be a gcc issue. I'm working on a patch to make tools/make-v8.sh compatible with clang -- I'm testing with it on top of the branch for this PR (it didn't work with main because we need patches to V8's build dep which should be okay with V8 14.1): https://ci.nodejs.org/job/richardlau-node-test-commit-v8-linux/732/

[miladfarca]

We no longer maintain gcc builds for RHEL on ppc64/s390x and builds now are using Clang. This patch which enables it on said platforms should already be part of 14.1: https://crrev.com/c/6705431

[targos]

CI: https://ci.nodejs.org/job/node-test-commit/82625/

[richardlau]

@nodejs/platform-ppc @nodejs/platform-s390 we quickly get a compiler error:

This might be a gcc issue. I'm working on a patch to make tools/make-v8.sh compatible with clang -- I'm testing with it on top of the branch for this PR (it didn't work with main because we need patches to V8's build dep which should be okay with V8 14.1): https://ci.nodejs.org/job/richardlau-node-test-commit-v8-linux/732/

With clang 19: https://ci.nodejs.org/job/richardlau-node-test-commit-v8-linux/732/nodes=rhel8-s390x,v8test=v8test/console

14:19:17 In file included from ../../src/builtins/generate-bytecodes-builtins-list.cc:8:
14:19:17 In file included from ../../src/interpreter/bytecodes.h:12:
14:19:17 In file included from ../../src/common/globals.h:16:
14:19:17 In file included from ../../src/base/atomic-utils.h:13:
14:19:17 In file included from ../../src/base/atomicops.h:40:
14:19:17 In file included from ../../src/base/macros.h:13:
14:19:17 ../../src/base/logging.h:268:31: error: expected concept name with optional arguments
14:19:17   268 |              { t.begin() } -> std::forward_iterator;
14:19:17       |                               ^
14:19:17 In file included from ../../src/builtins/generate-bytecodes-builtins-list.cc:8:
14:19:17 In file included from ../../src/interpreter/bytecodes.h:12:
14:19:17 In file included from ../../src/common/globals.h:22:
14:19:17 ../../src/base/numbers/double.h:8:10: fatal error: 'bit' file not found
14:19:17     8 | #include <bit>
14:19:17       |          ^~~~~
14:19:17 2 warnings and 2 errors generated.

Above is with:

+ gn gen -v out.gn/s390x.release '--args=is_clang=true clang_base_path="/usr" clang_use_chrome_plugins=false treat_warnings_as_errors=false is_component_build=false is_debug=false use_custom_libcxx=false v8_target_cpu="s390x" target_cpu="s390x" v8_enable_backtrace=true cc_wrapper="ccache"'

FWIW https://ci.nodejs.org/job/node-test-commit-linuxone/51470/ (also with clang-19) passed.

[targos]

Is it possible that it's using the wrong version of the C++ standard library? Both errors are related to C++20 features.

[richardlau]

Is it possible that it's using the wrong version of the C++ standard library? Both errors are related to C++20 features.

Quite possibly. Node.js built successfully with clang 19 for the equivalent platform: https://ci.nodejs.org/job/node-test-commit-linuxone/51470/

The IBM team that maintains the upstream Linux ppc64le and s390x ports build V8 with use_custom_libcxx = true. We can't currently do that with the V8 CI in Node.js unless we pull in more DEPS for V8: https://ci.nodejs.org/job/richardlau-node-test-commit-v8-linux/734/nodes=rhel8-s390x,v8test=v8test/console

[richardlau]

Is it possible that it's using the wrong version of the C++ standard library? Both errors are related to C++20 features.

So I compared command lines for compiling src/builtins/generate-bytecodes-builtins-list.cc in the (working) Node.js build and the (failing) V8 CI with clang 19 and it appears that the difference may be that the V8 build is passing --target=s390x-unknown-linux-gnu on the command line whereas we don't pass any --target value for the Node.js build.

On the LinuxONE machine:

[iojs@test-ibm-rhel8-s390x-3 ~]$ clang++ -v -xc++ -
clang version 19.1.7 ( 19.1.7-2.module+el8.10.0+23045+e1f8e80e)
Target: s390x-redhat-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
Configuration file: /etc/clang/s390x-redhat-linux-gnu-clang++.cfg
System configuration file directory: /etc/clang/
Selected GCC installation: /opt/rh/gcc-toolset-14/root//usr/lib/gcc/s390x-redhat-linux/14
Candidate multilib: .;@m64
Selected multilib: .;@m64
 "/usr/bin/clang-19" -cc1 -triple s390x-redhat-linux-gnu -emit-obj -dumpdir a- -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name - -mrelocation-model static -mframe-pointer=all -fmath-errno -ffp-contract=on -fno-rounding-math -mconstructor-aliases -funwind-tables=2 -target-cpu z10 -dwarf-version=4 -debugger-tuning=gdb -fdebug-compilation-dir=/home/iojs -v -fcoverage-compilation-dir=/home/iojs -resource-dir /usr/bin/../lib/clang/19 -internal-isystem /opt/rh/gcc-toolset-14/root//usr/lib/gcc/s390x-redhat-linux/14/../../../../include/c++/14 -internal-isystem /opt/rh/gcc-toolset-14/root//usr/lib/gcc/s390x-redhat-linux/14/../../../../include/c++/14/s390x-redhat-linux -internal-isystem /opt/rh/gcc-toolset-14/root//usr/lib/gcc/s390x-redhat-linux/14/../../../../include/c++/14/backward -internal-isystem /usr/bin/../lib/clang/19/include -internal-isystem /usr/local/include -internal-isystem /opt/rh/gcc-toolset-14/root//usr/lib/gcc/s390x-redhat-linux/14/../../../../s390x-redhat-linux/include -internal-externc-isystem /include -internal-externc-isystem /usr/include -fdeprecated-macro -ferror-limit 19 -fno-signed-char -fgnuc-version=4.2.1 -fskip-odr-check-in-gmf -fcxx-exceptions -fexceptions -fcolor-diagnostics -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /tmp/--98c169.o -x c++ -
clang -cc1 version 19.1.7 based upon LLVM 19.1.7 default target s390x-redhat-linux-gnu
ignoring nonexistent directory "/opt/rh/gcc-toolset-14/root//usr/lib/gcc/s390x-redhat-linux/14/../../../../s390x-redhat-linux/include"
ignoring nonexistent directory "/include"
#include "..." search starts here:
#include <...> search starts here:
 /opt/rh/gcc-toolset-14/root//usr/lib/gcc/s390x-redhat-linux/14/../../../../include/c++/14
 /opt/rh/gcc-toolset-14/root//usr/lib/gcc/s390x-redhat-linux/14/../../../../include/c++/14/s390x-redhat-linux
 /opt/rh/gcc-toolset-14/root//usr/lib/gcc/s390x-redhat-linux/14/../../../../include/c++/14/backward
 /usr/bin/../lib/clang/19/include
 /usr/local/include
 /usr/include
End of search list.

Note that the search paths point to the gcc-toolset-14 directories. Compare with passing --target=s390x-unknown-linux-gnu, which is searching the includes for the default (gcc 8):

[iojs@test-ibm-rhel8-s390x-3 ~]$ clang++ -v -xc++ --target=s390x-unknown-linux-gnu -
clang version 19.1.7 ( 19.1.7-2.module+el8.10.0+23045+e1f8e80e)
Target: s390x-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
System configuration file directory: /etc/clang/
Found candidate GCC installation: /usr/bin/../lib/gcc/s390x-redhat-linux/8
Selected GCC installation: /usr/bin/../lib/gcc/s390x-redhat-linux/8
Candidate multilib: .;@m64
Selected multilib: .;@m64
 "/usr/bin/clang-19" -cc1 -triple s390x-unknown-linux-gnu -emit-obj -dumpdir a- -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name - -mrelocation-model static -mframe-pointer=all -fmath-errno -ffp-contract=on -fno-rounding-math -mconstructor-aliases -funwind-tables=2 -target-cpu z10 -debugger-tuning=gdb -fdebug-compilation-dir=/home/iojs -v -fcoverage-compilation-dir=/home/iojs -resource-dir /usr/bin/../lib/clang/19 -internal-isystem /usr/bin/../lib/gcc/s390x-redhat-linux/8/../../../../include/c++/8 -internal-isystem /usr/bin/../lib/gcc/s390x-redhat-linux/8/../../../../include/c++/8/s390x-redhat-linux -internal-isystem /usr/bin/../lib/gcc/s390x-redhat-linux/8/../../../../include/c++/8/backward -internal-isystem /usr/bin/../lib/clang/19/include -internal-isystem /usr/local/include -internal-isystem /usr/bin/../lib/gcc/s390x-redhat-linux/8/../../../../s390x-redhat-linux/include -internal-externc-isystem /include -internal-externc-isystem /usr/include -fdeprecated-macro -ferror-limit 19 -fno-signed-char -fgnuc-version=4.2.1 -fskip-odr-check-in-gmf -fcxx-exceptions -fexceptions -fcolor-diagnostics -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /tmp/--5ab9ca.o -x c++ -
clang -cc1 version 19.1.7 based upon LLVM 19.1.7 default target s390x-redhat-linux-gnu
ignoring nonexistent directory "/usr/bin/../lib/gcc/s390x-redhat-linux/8/../../../../s390x-redhat-linux/include"
ignoring nonexistent directory "/include"
#include "..." search starts here:
#include <...> search starts here:
 /usr/bin/../lib/gcc/s390x-redhat-linux/8/../../../../include/c++/8
 /usr/bin/../lib/gcc/s390x-redhat-linux/8/../../../../include/c++/8/s390x-redhat-linux
 /usr/bin/../lib/gcc/s390x-redhat-linux/8/../../../../include/c++/8/backward
 /usr/bin/../lib/clang/19/include
 /usr/local/include
 /usr/include
End of search list.

I think the target is used to search for a config, e.g. in the default case it finds a configuration file /etc/clang/s390x-redhat-linux-gnu-clang++.cfg but nothing for when --target=s390x-unknown-linux-gnu is passed in. In /etc/clang:

[iojs@test-ibm-rhel8-s390x-3 ~]$ ls -al /etc/clang
total 16
drwxr-xr-x   2 root root 4096 Aug 14 21:00 .
drwxr-xr-x. 95 root root 4096 Aug 14 21:00 ..
-rw-r--r--   1 root root  128 Apr 22 18:08 s390x-redhat-linux-gnu-clang++.cfg
-rw-r--r--   1 root root  128 Apr 22 18:08 s390x-redhat-linux-gnu-clang.cfg
[iojs@test-ibm-rhel8-s390x-3 ~]$

and FWIW

[iojs@test-ibm-rhel8-s390x-3 ~]$ cat /etc/clang/s390x-redhat-linux-gnu-clang++.cfg
 --gcc-triple=s390x-redhat-linux -gdwarf-4 -g0 --gcc-install-dir=/opt/rh/gcc-toolset-14/root//usr/lib/gcc/s390x-redhat-linux/14
[iojs@test-ibm-rhel8-s390x-3 ~]$

I could try creating a s390x-unknown-linux-gnu-clang++.cfg configuration file with the same contents as the existing /etc/clang/s390x-redhat-linux-gnu-clang++.cfg.

[targos]

@nodejs/platform-windows

There are two issues on Windows:

test-worker-prof

https://ci.nodejs.org/job/node-test-binary-windows-js-suites/36755/RUN_SUBSET=2,nodes=win11-COMPILED_BY-vs2022_clang/testReport/junit/(root)/sequential/test_worker_prof/

stack: |-
  files found in working directory before worker starts [ 'isolate-0000010BE1037000-4700-v8.log' ]
  parent prof file: isolate-0000010BE1037000-4700-v8.log
  parent posted 27193 messages
  files found in working directory before worker exits [
    'isolate-0000010BE1037000-4700-v8.log',
    'isolate-0000010BFAD02000-4700-v8.log'
  ]
  worker prof file: isolate-0000010BFAD02000-4700-v8.log

  worker ticks 22
  parent ticks 15
  node:internal/assert/utils:273
      throw err;
      ^

  AssertionError [ERR_ASSERTION]: parent ticks <= 15:
  tick,0x7ff71a1f64fb,178574,0,0x0,0,0x10b800404be,0x10b80040287,0x175c76919de,0x10b8004058f,0x10b80040287,0x175c7691013,0x10b8004058f,0x10b80040287,0x175c7690b1b,0x10b8004058f,0x10b80040287,0x175c768f546,0x10b8004058f,0x10b80040287,0x175c768ea0d,0x10b8004058f,0x10b80040287,0x175c768d68c,0x10b8004058f,0x10b80040287,0x2dec04bdf53,0x2dec04be787,0x175c768bdd8,0x175c768bc98,0x10b8004058f,0x10b80040287,0x175c768b9f5,0x10b8004058f,0x10b80040287,0x175c768b1ef,0x10b8004058f,0x37f43704c4c,0x2dec049bca0,0x36a03805d86,0x36a03805fa2,0x2dec0481120,0x36a03802793,0x36a03806e82,0x2dec049bfc8,0x175c7689a31,0x36a0380787f,0x36a03808142,0x36a03806d0f,0x36a03806064,0x2dec0481120,0x36a03802793,0x36a03806e82,0x2dec049bfc8,0x175c7688346,0x36a0380787f,0x36a03808142,0x36a03806d0f,0x36a03806064,0x2dec0481120,0x36a03802793,0x36a038106af,0x175c7686530
  tick,0x7ff71a20cb80,226434,0,0x0,5,0x10b800404be,0x10b80040287,0x175c76a552c,0x10b8004058f,0x10b80040287,0x175c76a386b,0x10b8004058f,0x10b80040287,0x37f43717b02,0x10b9fe7b4fa,0x175c76a2fce,0x10b9fe957e7,0x175c768a08c,0x36a0380787f,0x36a03808142,0x36a03806d0f,0x36a03806064,0x2dec0481120,0x36a03802793,0x36a03806e82,0x2dec049bfc8,0x175c7688346,0x36a0380787f,0x36a03808142,0x36a03806d0f,0x36a03806064,0x2dec0481120,0x36a03802793,0x36a038106af,0x175c7686530
  tick,0x10b9fdc214c,593487,0,0x0,0,0x10b80089f22,0x10b80052673,0x10b8008b342
  tick,0x7ffec9025f04,672525,0,0x0,0,0x10b8008a16e,0x10b80053ee0,0x10b80089f22,0x10b80052673,0x10b8008b342
  tick,0x10b9fe2d78d,750822,0,0x0,0
  tick,0x7ff71a6d51db,941880,0,0x0,5
  tick,0x10b9fe2d78d,957889,0,0x0,0
  tick,0x7ff71a328560,1021010,0,0x0,5
  tick,0x7ffec9025f04,1069003,0,0x0,0,0x10b8008a16e,0x10b80053ee0,0x10b80089f22,0x10b8008ba66,0x10b8008b342
  tick,0x7ffec9025f04,1100146,0,0x0,0,0x10b8008a16e,0x10b80053ee0,0x10b80089f22,0x10b8008ba66,0x10b8008b342
  tick,0x7ff71a6d51df,1260265,0,0x0,5
  tick,0x7ffec9025f04,1308053,0,0x0,0,0x10b8008c3f0,0x10b8008c666,0x10b8008ba66,0x10b8008b342
  tick,0x7ff719c09980,1355086,0,0x0,0,0x10b8008c3f0,0x10b8008c666,0x10b8008ba66,0x10b8008b342
  tick,0x7ffec9025f04,1499289,0,0x0,0,0x10b8008c3f0,0x10b8008c666,0x10b8008ba66,0x10b8008b342
  tick,0x0,1514647,0,0x0,5
      at Object.<anonymous> (c:\workspace\node-test-binary-windows-js-suites\node\test\sequential\test-worker-prof.js:82:3)
      at Module._compile (node:internal/modules/cjs/loader:1737:14)
      at Object..js (node:internal/modules/cjs/loader:1870:10)
      at Module.load (node:internal/modules/cjs/loader:1469:32)
      at Module._load (node:internal/modules/cjs/loader:1289:12)
      at TracingChannel.traceSync (node:diagnostics_channel:322:14)
      at wrapModuleLoad (node:internal/modules/cjs/loader:238:24)
      at Module.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:154:5)
      at node:internal/main/run_main_module:33:47 {
    generatedMessage: false,
    code: 'ERR_ASSERTION',
    actual: false,
    expected: true,
    operator: '==',
    diff: 'simple'
  }

  Node.js v25.0.0-pre

cppgc addon

https://ci.nodejs.org/job/node-test-binary-windows-native-suites/29658/nodes=win10-vs2019-COMPILED_BY-vs2022_clang/console

18:33:56 c:\workspace\node-test-binary-windows-native-suites\node\test\addons\cppgc-object\binding.cc(24,11): warning C4996: 'node::SetCppgcReference': was declared deprecated [c:\workspace\node-test-binary-windows-native-suites\node\test\addons\cppgc-object\build\binding.vcxproj]
18:33:56 
18:33:56   win_delay_load_hook.cc
18:33:56 
18:33:56 LINK : fatal error LNK1194: cannot delay-load 'node.exe' due to import of data symbol '"__declspec(dllimport) const cppgc::NameProvider::`vftable'" (__imp_??_7NameProvider@cppgc@@6B@)'; link without /DELAYLOAD:node.exe [c:\workspace\node-test-binary-windows-native-suites\node\test\addons\cppgc-object\build\binding.vcxproj]
18:33:56 
18:33:56 

[richardlau]

wrt. the V8 CI on Linux ppc64le and s390x. I have opened #59893 and nodejs/build#4153 which combined with this PR has enabled the V8 CI to build with clang. I also updated the Jenkins job to erase the --target parameter to avoid the vendor mismatch in the target triplet.

This test CI is a combination of the above changes and this PR: https://ci.nodejs.org/job/richardlau-node-test-commit-v8-linux/746/
It passed on Linux s390x.
On Linux ppc64le it compiled successfully but fails two tests (cc @nodejs/platform-ppc ). I don't know if that a missing fix, or due to using gcc atomics instead of V8's custom libcxx.
e.g. https://ci.nodejs.org/job/richardlau-node-test-commit-v8-linux/746/nodes=rhel8-ppc64le,v8test=v8test/console

02:49:19 === mjsunit/wasm/compare-exchange-stress ===
02:49:19 --- stderr ---
02:49:19 #
02:49:19 # Fatal error in , line 0
02:49:19 # d8: Received SIGTERM signal (likely due to a TIMEOUT)
02:49:19 
02:49:19 #
02:49:19 #
02:49:19 #
02:49:19 #FailureMessage Object: 0x7ffff55e4d50
02:49:19 ==== C stack trace ===============================
02:49:19 
02:49:19     out.gn/ppc64.release/d8(v8::base::debug::StackTrace::StackTrace()+0x2c) [0x126d527ac]
02:49:19     out.gn/ppc64.release/d8(+0x2e6151c) [0x126d5151c]
02:49:19     out.gn/ppc64.release/d8(V8_Fatal(char const*, ...)+0x1a0) [0x126d3dc00]
02:49:19     out.gn/ppc64.release/d8(+0x1297bd4) [0x125187bd4]
02:49:19     linux-vdso64.so.1(__kernel_sigtramp_rt64+0) [0x7fff8e5704d8]
02:49:19     /lib64/libpthread.so.0(+0x161f0) [0x7fff8e4c61f0]
02:49:19     /lib64/libpthread.so.0(+0x163a8) [0x7fff8e4c63a8]
02:49:19     out.gn/ppc64.release/d8(v8::base::Semaphore::Wait()+0x48) [0x126d46068]
02:49:19     out.gn/ppc64.release/d8(void heap::base::Stack::SetMarkerAndCallbackImpl<v8::internal::LocalHeap::ExecuteWhileParked<v8::internal::ParkingSemaphore::ParkedWait(v8::internal::LocalHeap*)::{lambda(v8::internal::ParkedScope const&)#1}>(v8::internal::ParkingSemaphore::ParkedWait(v8::internal::LocalHeap*)::{lambda(v8::internal::ParkedScope const&)#1})::{lambda()#1}>(heap::base::Stack*, void*, void const*)+0x94) [0x125183d64]
02:49:19     out.gn/ppc64.release/d8(+0x1e4940c) [0x125d3940c]
02:49:19     out.gn/ppc64.release/d8(heap::base::Stack::TrampolineCallbackHelper(void*, void (*)(heap::base::Stack*, void*, void const*))+0x20) [0x125d38f50]
02:49:19     out.gn/ppc64.release/d8(v8::Worker::GetMessage(v8::Isolate*)+0x128) [0x12516be88]
02:49:19     out.gn/ppc64.release/d8(v8::Shell::WorkerGetMessage(v8::FunctionCallbackInfo<v8::Value> const&)+0x88) [0x12516bb98]
02:49:19     out.gn/ppc64.release/d8(+0x2b5d30c) [0x126a4d30c]
02:49:19 Received signal 6
02:49:19 --- stdout ---
02:49:19 Testing I32AtomicCompareExchange32
02:49:19 DONE
02:49:19 Testing I32AtomicCompareExchange16
02:49:19 Command: out.gn/ppc64.release/d8 --test test/mjsunit/mjsunit.js test/mjsunit/wasm/compare-exchange-stress.js --random-seed=-133725566 --nohard-abort --testing-d8-test-runner
02:49:19 --- TIMEOUT ---
02:49:19 === mjsunit/wasm/compare-exchange64-stress ===
02:49:19 --- stderr ---
02:49:19 #
02:49:19 # Fatal error in , line 0
02:49:19 # d8: Received SIGTERM signal (likely due to a TIMEOUT)
02:49:19 
02:49:19 #
02:49:19 #
02:49:19 #
02:49:19 #FailureMessage Object: 0x7fffddf969c0
02:49:19 ==== C stack trace ===============================
02:49:19 
02:49:19     out.gn/ppc64.release/d8(v8::base::debug::StackTrace::StackTrace()+0x2c) [0x1380c27ac]
02:49:19     out.gn/ppc64.release/d8(+0x2e6151c) [0x1380c151c]
02:49:19     out.gn/ppc64.release/d8(V8_Fatal(char const*, ...)+0x1a0) [0x1380adc00]
02:49:19     out.gn/ppc64.release/d8(+0x1297bd4) [0x1364f7bd4]
02:49:19     linux-vdso64.so.1(__kernel_sigtramp_rt64+0) [0x7fffa3d104d8]
02:49:19     /lib64/libpthread.so.0(+0x161f0) [0x7fffa3c661f0]
02:49:19     /lib64/libpthread.so.0(+0x163a8) [0x7fffa3c663a8]
02:49:19     out.gn/ppc64.release/d8(v8::base::Semaphore::Wait()+0x48) [0x1380b6068]
02:49:19     out.gn/ppc64.release/d8(void heap::base::Stack::SetMarkerAndCallbackImpl<v8::internal::LocalHeap::ExecuteWhileParked<v8::internal::ParkingSemaphore::ParkedWait(v8::internal::LocalHeap*)::{lambda(v8::internal::ParkedScope const&)#1}>(v8::internal::ParkingSemaphore::ParkedWait(v8::internal::LocalHeap*)::{lambda(v8::internal::ParkedScope const&)#1})::{lambda()#1}>(heap::base::Stack*, void*, void const*)+0x94) [0x1364f3d64]
02:49:19     out.gn/ppc64.release/d8(+0x1e4940c) [0x1370a940c]
02:49:19     out.gn/ppc64.release/d8(heap::base::Stack::TrampolineCallbackHelper(void*, void (*)(heap::base::Stack*, void*, void const*))+0x20) [0x1370a8f50]
02:49:19     out.gn/ppc64.release/d8(v8::Worker::GetMessage(v8::Isolate*)+0x128) [0x1364dbe88]
02:49:19     out.gn/ppc64.release/d8(v8::Shell::WorkerGetMessage(v8::FunctionCallbackInfo<v8::Value> const&)+0x88) [0x1364dbb98]
02:49:19     out.gn/ppc64.release/d8(+0x2b5d30c) [0x137dbd30c]
02:49:19 Received signal 6
02:49:19 --- stdout ---
02:49:19 Testing I64AtomicCompareExchange64
02:49:19 DONE
02:49:19 Testing I64AtomicCompareExchange32
02:49:19 Command: out.gn/ppc64.release/d8 --test test/mjsunit/mjsunit.js test/mjsunit/wasm/compare-exchange64-stress.js --random-seed=-133725566 --nohard-abort --testing-d8-test-runner
02:49:19 --- TIMEOUT ---
02:49:19 
02:49:19 ===
02:49:19 === 2 tests failed
02:49:19 ===

[Dhruv-Garg79]

will we get this in v24?

[atlowChemi]

will we get this in v24?

No, this is a semver-major PRs that contain breaking changes and should be released in the next major version. , meaning it will not be landing in any existing release line