Skip to content

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Aug 12, 2025

Two small changes that should be rather safe, but it's probably a better idea not to backport to avoid breaking anyone (not sure if it qualifies as semver-major):

  • remove self-ref assert.ok.ok.ok…, I doubt anyone is using it.
  • require('node:assert').name is now assert instead of ok – for the sake of having clearer stack traces.

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. needs-ci PRs that need a full CI run. labels Aug 12, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Aug 12, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2025
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.87%. Comparing base (eed1d33) to head (4cc820b).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59451      +/-   ##
==========================================
- Coverage   89.89%   89.87%   -0.02%     
==========================================
  Files         656      656              
  Lines      192947   192953       +6     
  Branches    37834    37846      +12     
==========================================
- Hits       173443   173419      -24     
- Misses      12054    12086      +32     
+ Partials     7450     7448       -2     
Files with missing lines Coverage Δ
lib/assert.js 98.13% <100.00%> (-0.01%) ⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 12, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 14, 2025
@nodejs-github-bot nodejs-github-bot merged commit 91f035e into nodejs:main Aug 14, 2025
85 of 86 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 91f035e

@aduh95 aduh95 deleted the rename-assert branch August 14, 2025 13:16
meteorqz6 pushed a commit to meteorqz6/node that referenced this pull request Aug 15, 2025
PR-URL: nodejs#59451
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
panva pushed a commit to panva/node that referenced this pull request Aug 18, 2025
PR-URL: nodejs#59451
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants