doc: remove broken link to permission model source code #58972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The permission model grew enough to be splited into multiple files, the link in the md file is broken. And as it is not part of a single file, the best way to fix this is just remove the link, many APIs in Node.js does not have the source code linked, this is not bad for our docs. Signed-off-by: Juan José Arboleda <[email protected]>
|
Review requested:
|
RafaelGSS
approved these changes
Jul 6, 2025
UlisesGascon
approved these changes
Jul 6, 2025
lpinca
approved these changes
Jul 6, 2025
juanarbol
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 41cd6ba |
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 8, 2025
The permission model grew enough to be splited into multiple files, the link in the md file is broken. And as it is not part of a single file, the best way to fix this is just remove the link, many APIs in Node.js does not have the source code linked, this is not bad for our docs. Signed-off-by: Juan José Arboleda <[email protected]> PR-URL: #58972 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2025
The permission model grew enough to be splited into multiple files, the link in the md file is broken. And as it is not part of a single file, the best way to fix this is just remove the link, many APIs in Node.js does not have the source code linked, this is not bad for our docs. Signed-off-by: Juan José Arboleda <[email protected]> PR-URL: #58972 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 24, 2025
The permission model grew enough to be splited into multiple files, the link in the md file is broken. And as it is not part of a single file, the best way to fix this is just remove the link, many APIs in Node.js does not have the source code linked, this is not bad for our docs. Signed-off-by: Juan José Arboleda <[email protected]> PR-URL: #58972 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 27, 2025
The permission model grew enough to be splited into multiple files, the link in the md file is broken. And as it is not part of a single file, the best way to fix this is just remove the link, many APIs in Node.js does not have the source code linked, this is not bad for our docs. Signed-off-by: Juan José Arboleda <[email protected]> PR-URL: #58972 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The permission model grew enough to be splited into multiple files, the link in the md file is broken. And as it is not part of a single file, the best way to fix this is just remove the link, many APIs in Node.js does not have the source code linked, this is not bad for our docs.
The link is pointing to https://github.com/nodejs/node/blob/v24.3.0/src/permission.cc, which is a "404". Everything is under
src/permission/*.{cc,h}not a single file.