Skip to content

Conversation

dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Jul 3, 2025

While trying to deflake the tests I've refactored making them much clearer and more performant (since there are no longer setTimeout calls), as far as I can tell the flake is also gone 🙂

Results:

Ref: nodejs/reliability#1250

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 3, 2025
@nodejs-github-bot
Copy link
Collaborator

@dario-piotrowicz dario-piotrowicz added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jul 3, 2025
@dario-piotrowicz dario-piotrowicz force-pushed the dario/deflake-watch-mode-kill-signal-test branch 2 times, most recently from c40725d to 4c1b29f Compare July 3, 2025 23:19
@dario-piotrowicz dario-piotrowicz force-pushed the dario/deflake-watch-mode-kill-signal-test branch from 4c1b29f to 971a1ac Compare July 4, 2025 23:04
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review July 5, 2025 00:02
@codecov
Copy link

codecov bot commented Jul 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (aad9030) to head (971a1ac).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58952      +/-   ##
==========================================
+ Coverage   89.96%   90.06%   +0.09%     
==========================================
  Files         640      640              
  Lines      188454   188471      +17     
  Branches    36892    36979      +87     
==========================================
+ Hits       169546   169739     +193     
+ Misses      11608    11430     -178     
- Partials     7300     7302       +2     

see 61 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ethan-Arrowood Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@dario-piotrowicz dario-piotrowicz added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 7, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 7, 2025
@nodejs-github-bot nodejs-github-bot merged commit 35c85a2 into nodejs:main Jul 7, 2025
78 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 35c85a2

@dario-piotrowicz dario-piotrowicz deleted the dario/deflake-watch-mode-kill-signal-test branch July 7, 2025 21:17
RafaelGSS pushed a commit that referenced this pull request Jul 8, 2025
PR-URL: #58952
Refs: nodejs/reliability#1250
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
PR-URL: #58952
Refs: nodejs/reliability#1250
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
PR-URL: #58952
Refs: nodejs/reliability#1250
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
aduh95 pushed a commit that referenced this pull request Jul 27, 2025
PR-URL: #58952
Refs: nodejs/reliability#1250
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants