doc: clarify details of TSC public and private meetings #58925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
jasnell
added
the
tsc-agenda
aduh95
reviewed
Jul 2, 2025
aduh95
reviewed
Jul 2, 2025
aduh95
reviewed
Jul 2, 2025
jasnell
commented
Jul 2, 2025
Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]>
jasnell
commented
Jul 2, 2025
joyeecheung
reviewed
Jul 2, 2025
Co-authored-by: Joyee Cheung <[email protected]>
Co-authored-by: Joyee Cheung <[email protected]>
aduh95
approved these changes
Jul 2, 2025
joyeecheung
reviewed
Jul 2, 2025
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
Mostly LGTM, thanks. Still have a suggestion to align it with what we are already doing since that seems already good enough + a wording suggestion to make it more accurate.
Co-authored-by: Joyee Cheung <[email protected]>
Co-authored-by: Joyee Cheung <[email protected]>
marco-ippolito
approved these changes
Jul 4, 2025
targos
approved these changes
Jul 4, 2025
joyeecheung
approved these changes
Jul 4, 2025
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
LGTM % a wording suggestion. Thanks for putting it together :)
RafaelGSS
approved these changes
Jul 4, 2025
Co-authored-by: Joyee Cheung <[email protected]>
Member
Author
|
@nodejs/tsc ... please take a look if you haven't done so already. I think this is ready to land. I'll merge end-of-day Monday if there are no objections posted. |
RaisinTen
approved these changes
Jul 7, 2025
MoLow
approved these changes
Jul 7, 2025
jasnell
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in a86765a |
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 8, 2025
PR-URL: #58925 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2025
PR-URL: #58925 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 24, 2025
PR-URL: #58925 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 27, 2025
PR-URL: #58925 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #58837
To be clear, I don't think any changes to our governance doc are needed, but others have proposed edits and additional requirements. This PR represents the version of those changes that I think would be better if any changes are made at all. See the discussion in #58837 for background.