- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 33.7k
 
doc: fix wrong RFC number in http2 #58753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            nodejs-github-bot
  merged 1 commit into
  nodejs:main
from
deokjinkim:250618_fix_wrong_rfc_number
  
      
      
   
  Jun 20, 2025 
      
    
                
     Merged
            
            doc: fix wrong RFC number in http2 #58753
                    nodejs-github-bot
  merged 1 commit into
  nodejs:main
from
deokjinkim:250618_fix_wrong_rfc_number
  
      
      
   
  Jun 20, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Priority signaling was deprecated in RFC 9113(not 1993). Refs: nodejs#58313
| 
           Review requested: 
  | 
    
              
                    pimterry
  
              
              approved these changes
              
                  
                    Jun 18, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot! Looks like we missed this in the previous fix #58669
              
                    RafaelGSS
  
              
              approved these changes
              
                  
                    Jun 18, 2025 
                  
              
              
            
            
              
                    Ethan-Arrowood
  
              
              approved these changes
              
                  
                    Jun 18, 2025 
                  
              
              
            
            
              
                    lpinca
  
              
              approved these changes
              
                  
                    Jun 18, 2025 
                  
              
              
            
            
              
                    trivikr
  
              
              approved these changes
              
                  
                    Jun 19, 2025 
                  
              
              
            
            
| 
           Oops, missed one place in previous fix. haha  | 
    
              
                    gurgunday
  
              
              approved these changes
              
                  
                    Jun 19, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
              
                    JungMinu
  
              
              approved these changes
              
                  
                    Jun 20, 2025 
                  
              
              
            
            
              
                    aymen94
  
              
              approved these changes
              
                  
                    Jun 20, 2025 
                  
              
              
            
            
| 
           Landed in 98433c7  | 
    
    
  RafaelGSS 
      pushed a commit
      that referenced
      this pull request
    
      Jun 23, 2025 
    
    
      
  
    
      
    
  
Priority signaling was deprecated in RFC 9113(not 1993). Refs: #58313 PR-URL: #58753 Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
  This was referenced Jun 23, 2025 
      
    
  aduh95 
      pushed a commit
      that referenced
      this pull request
    
      Jul 21, 2025 
    
    
      
  
    
      
    
  
Priority signaling was deprecated in RFC 9113(not 1993). Refs: #58313 PR-URL: #58753 Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
    
  aduh95 
      pushed a commit
      that referenced
      this pull request
    
      Jul 24, 2025 
    
    
      
  
    
      
    
  
Priority signaling was deprecated in RFC 9113(not 1993). Refs: #58313 PR-URL: #58753 Reviewed-By: Tim Perry <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    author ready
  PRs that have at least one approval, no pending requests for changes, and a CI started. 
  
    doc
  Issues and PRs related to the documentations. 
  
    http2
  Issues or PRs related to the http2 subsystem. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Priority signaling was deprecated in RFC 9113(not 1993).
Refs: #58313