doc: fix jsdoc definition of assert.ifError() fn in lib/assert.js #58573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
assert
jasnell
approved these changes
Jun 4, 2025
UlisesGascon
approved these changes
Jun 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58573 +/- ##
=======================================
Coverage 90.21% 90.22%
=======================================
Files 635 635
Lines 187484 187494 +10
Branches 36842 36837 -5
=======================================
+ Hits 169146 169158 +12
+ Misses 11110 11108 -2
Partials 7228 7228
🚀 New features to boost your workflow:
|
tniessen
approved these changes
Jun 4, 2025
There was a problem hiding this comment.
LGTM. Before this can land, could you please change the commit message to adhere to the commit message guidelines, which require that the commit message title begins with the subsystem followed by an imperative verb?
In other words, use doc: fix ... instead of doc: fixed ....
Thank you.
pr4j3sh
changed the title
ljharb
approved these changes
Jun 4, 2025
mertcanaltin
approved these changes
Jun 4, 2025
UlisesGascon
added
the
author ready
marco-ippolito
approved these changes
Jun 5, 2025
atlowChemi
approved these changes
Jun 5, 2025
lpinca
approved these changes
Jun 14, 2025
lpinca
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/58573 ✔ Done loading data for nodejs/node/pull/58573 ----------------------------------- PR info ------------------------------------ Title doc: fix jsdoc definition of assert.ifError() fn in lib/assert.js (#58573) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch pr4j3sh:main -> nodejs:main Labels assert, author ready Commits 1 - doc: fix jsdoc definition of assert.ifError() fn in lib/assert.js Committers 1 - pr4j3sh <[email protected]> PR-URL: https://github.com/nodejs/node/pull/58573 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58573 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 04 Jun 2025 12:36:54 GMT ✔ Approvals: 7 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58573#pullrequestreview-2896754404 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/58573#pullrequestreview-2896765115 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/58573#pullrequestreview-2897346481 ✔ - Jordan Harband (@ljharb): https://github.com/nodejs/node/pull/58573#pullrequestreview-2897483081 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/58573#pullrequestreview-2900419541 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/58573#pullrequestreview-2902131786 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/58573#pullrequestreview-2928434402 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/15653351751 |
lpinca
added
request-ci
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
aymen94
approved these changes
Jun 27, 2025
marco-ippolito
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in eaebfab |
targos
pushed a commit
that referenced
this pull request
Jul 3, 2025
PR-URL: #58573 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2025
PR-URL: #58573 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 24, 2025
PR-URL: #58573 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #58572
Fixed definition of
assert.ifError()in `lib/assert.js