Skip to content

deps: support madvise(3C) across ALL illumos revisions #58237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025
+14 −2
Merged

deps: support madvise(3C) across ALL illumos revisions #58237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.17',
'v8_embedder_string': '-node.18',

##### V8 defaults for Node.js #####

Expand Down
14 changes: 13 additions & 1 deletion deps/v8/src/base/platform/platform-posix.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,19 @@
#define MAP_ANONYMOUS MAP_ANON
#endif

#if defined(V8_OS_SOLARIS)
/*
* NOTE: illumos starting with illumos#14418 (pushed April 20th, 2022)
* prototypes madvise(3C) properly with a `void *` first argument.
* The only way to detect this outside of configure-time checking is to
* check for the existence of MEMCNTL_SHARED, which gets defined for the first
* time in illumos#14418 under the same circumstances save _STRICT_POSIX, which
* thankfully neither Solaris nor illumos builds of Node or V8 do.
*
* If some future illumos push changes the MEMCNTL_SHARED assumptions made
* above, the illumos check below will have to be revisited. This check
* will work on both pre-and-post illumos#14418 illumos environments.
*/
#if defined(V8_OS_SOLARIS) && !(defined(__illumos__) && defined(MEMCNTL_SHARED))
#if (defined(_POSIX_C_SOURCE) && _POSIX_C_SOURCE > 2) || defined(__EXTENSIONS__)
extern "C" int madvise(caddr_t, size_t, int);
#else
Expand Down
Loading