- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.6k
src: add a couple fast apis in node_os #58210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@            Coverage Diff             @@
##             main   #58210      +/-   ##
==========================================
+ Coverage   90.18%   90.21%   +0.02%     
==========================================
  Files         631      633       +2     
  Lines      186690   186852     +162     
  Branches    36666    36677      +11     
==========================================
+ Hits       168360   168560     +200     
+ Misses      11126    11093      -33     
+ Partials     7204     7199       -5     
 🚀 New features to boost your workflow:
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is LGTM, it would just be good to get some rests that verify the behavior as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @BridgeAR, can we add some tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
e7847f4    to
    5d581b4      
    Compare
  
    5d581b4    to
    8ace295      
    Compare
  
    PR-URL: #58210 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
| Landed in 292263e | 
PR-URL: #58210 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #58210 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Couple of small fast api additions