src: skip calling object setters #57942
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
anonrig
approved these changes
Apr 20, 2025
anonrig
added
author ready
jasnell
approved these changes
Apr 20, 2025
anonrig
added
the
commit-queue
cjihrig
approved these changes
Apr 20, 2025
anonrig
approved these changes
Apr 20, 2025
geeksilva97
approved these changes
Apr 20, 2025
github-actions
bot
removed
the
request-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #57942 +/- ##
==========================================
- Coverage 92.26% 90.26% -2.00%
==========================================
Files 325 630 +305
Lines 126673 186110 +59437
Branches 20783 36471 +15688
==========================================
+ Hits 116869 167991 +51122
- Misses 9576 10981 +1405
- Partials 228 7138 +6910
🚀 New features to boost your workflow:
|
|
@JonasBa it seems there is a single test failing |
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/57942 ✔ Done loading data for nodejs/node/pull/57942 ----------------------------------- PR info ------------------------------------ Title src: skip calling object setters (#57942) Author Jonas <[email protected]> (@JonasBa) Branch JonasBa:jb/sqlite-obj -> nodejs:main Labels c++, author ready, needs-ci, sqlite Commits 3 - src: skip calling object setters - fixup! src: skip calling object setters - fixup! fixup! src: skip calling object setters Committers 1 - JonasBa <[email protected]> PR-URL: https://github.com/nodejs/node/pull/57942 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Edy Silva <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57942 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Edy Silva <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 20 Apr 2025 01:03:34 GMT ✔ Approvals: 4 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/57942#pullrequestreview-2780124749 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57942#pullrequestreview-2780122974 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/57942#pullrequestreview-2780123409 ✔ - Edy Silva (@geeksilva97): https://github.com/nodejs/node/pull/57942#pullrequestreview-2780125616 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-04-20T01:52:20Z: https://ci.nodejs.org/job/node-test-pull-request/66375/ - Querying data for job/node-test-pull-request/66375/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/14584656089 |
aduh95
added
stalled
|
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
|
Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can call Object constructor directly without calling the setter methods and checking if they fail.