Skip to content

Conversation

alexsch01
Copy link
Contributor

@alexsch01 alexsch01 commented Nov 5, 2024

This reverts commit a833c9e.

PR-URL: #54677
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@nodejs-github-bot nodejs-github-bot added console Issues and PRs related to the console subsystem. needs-ci PRs that need a full CI run. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Nov 5, 2024
@alexsch01 alexsch01 changed the title Revert "console: colorize console error and warn" [v20.x] Revert "console: colorize console error and warn" Nov 5, 2024
@avivkeller
Copy link
Member

avivkeller commented Nov 5, 2024

Please change the base branch to v20.x-staging.

Again, I don't think this even needs a backport PR, as the commit lands cleanly, and can be included in the next release

@alexsch01 alexsch01 deleted the branch nodejs:v20.x November 5, 2024 17:12
@alexsch01 alexsch01 closed this Nov 5, 2024
@alexsch01 alexsch01 deleted the v20.x branch November 5, 2024 17:12
@alexsch01
Copy link
Contributor Author

@redyetidev does renaming my branch and doing another PR work?

@avivkeller
Copy link
Member

avivkeller commented Nov 5, 2024

IMHO I would hold off on the backport PR, and see if it is even needed. I'd wait until v20.X is prepared, and then see if it's even needed

@alexsch01 alexsch01 changed the title [v20.x] Revert "console: colorize console error and warn" - Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

console Issues and PRs related to the console subsystem. needs-ci PRs that need a full CI run. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants