Skip to content

test_runner: allow --import with no isolation #54697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 9, 2024
Merged

test_runner: allow --import with no isolation #54697

merged 4 commits into from
Sep 9, 2024

Conversation

avivkeller
Copy link
Member

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 1, 2024
cjihrig
cjihrig approved these changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI passes.

@avivkeller avivkeller force-pushed the allow-import-isolation branch from dc2d2bf to e5d7070 Compare September 1, 2024 16:59
@codecov Codecov
Copy link

codecov bot commented Sep 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.60%. Comparing base (71b36b3) to head (c7ff451).
Report is 257 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54697      +/-   ##
==========================================
- Coverage   87.61%   87.60%   -0.02%     
==========================================
  Files         650      650              
  Lines      182834   182840       +6     
  Branches    35382    35386       +4     
==========================================
- Hits       160194   160175      -19     
- Misses      15925    15931       +6     
- Partials     6715     6734      +19
Files with missing lines Coverage Δ
lib/internal/test_runner/runner.js 87.99% <100.00%> (+0.09%) ⬆️

... and 36 files with indirect coverage changes

@avivkeller
Copy link
Member Author

Github CI is passing, could you start a Jenkins CI, I don't think I have permission to start one without an approval after the push.

@cjihrig cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
aduh95
aduh95 reviewed Sep 1, 2024
View reviewed changes
aduh95
aduh95 reviewed Sep 1, 2024
View reviewed changes
@avivkeller
Copy link
Member Author

FWIW tests appear to pass either way.

@avivkeller avivkeller added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 1, 2024
mcollina
mcollina approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
benjamingr
benjamingr approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62125/

@jasnell
Copy link
Member

jasnell commented Sep 8, 2024

PR is currently blocked from landing due to unreliable CI. Looks like the OSX runner is jammed up.

@cjihrig
Copy link
Contributor

cjihrig commented Sep 9, 2024

Is there any path to landing things while macOS is having issues?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62203/

@aduh95 aduh95 merged commit 5c8d0eb into nodejs:main Sep 9, 2024
23 of 29 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Sep 9, 2024

Landed in 5c8d0eb

@cjihrig cjihrig mentioned this pull request Sep 10, 2024
Merged
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@avivkeller @cjihrig @aduh95
test_runner: allow --import with no isolation
c765b59 
Co-Authored-By: Colin Ihrig <[email protected]>
PR-URL: #54697
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Sep 16, 2024
@avivkeller @cjihrig @RafaelGSS
test_runner: allow --import with no isolation
c69ae89 
Co-Authored-By: Colin Ihrig <[email protected]>
PR-URL: #54697
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
@avivkeller @cjihrig @RafaelGSS
test_runner: allow --import with no isolation
36da793 
Co-Authored-By: Colin Ihrig <[email protected]>
PR-URL: #54697
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 22, 2024
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@avivkeller @cjihrig @louwers
test_runner: allow --import with no isolation
124dd8b 
Co-Authored-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#54697
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@avivkeller @cjihrig @tpoisseau
test_runner: allow --import with no isolation
6e8e9ef 
Co-Authored-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#54697
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 left review comments

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@MoLow MoLow MoLow approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@avivkeller @nodejs-github-bot @jasnell @cjihrig @aduh95 @mcollina @benjamingr @MoLow @atlowChemi @targos