fs: avoid unnecessary options checks when options argument is not passed #53861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
anonrig
approved these changes
Jul 15, 2024
anonrig
added
request-ci
|
cc @nodejs/fs |
JonasBa
force-pushed
the
jb/fs-mkdirsync/lazy
branch
from
78b1e27 to
ce7a3c2
Compare
anonrig
approved these changes
Jul 15, 2024
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Jul 16, 2024
anonrig
added
the
commit-queue
H4ad
approved these changes
Jul 16, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in bcec922 |
|
@JonasBa Congratz on your first PR o/ |
ehsankhfr
pushed a commit
to ehsankhfr/node
that referenced
this pull request
Jul 18, 2024
PR-URL: nodejs#53861 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 28, 2024
PR-URL: #53861 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Merged
targos
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary option parsing when options argv is undefined