crypto: improve GetECGroupBits signature #53364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniessen
added
crypto
|
Review requested:
|
panva
approved these changes
Jun 6, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
request-ci
tniessen
added
the
author ready
Remove the unused ECPointer argument and rename the function since the current name is misleading.
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
tniessen
removed
the
author ready
lpinca
approved these changes
Jun 10, 2024
tniessen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in dbf79c9 |
targos
pushed a commit
that referenced
this pull request
Jun 20, 2024
Remove the unused ECPointer argument and rename the function since the current name is misleading. PR-URL: #53364 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
sophoniie
pushed a commit
to sophoniie/node
that referenced
this pull request
Jun 20, 2024
Remove the unused ECPointer argument and rename the function since the current name is misleading. PR-URL: nodejs#53364 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
Remove the unused ECPointer argument and rename the function since the current name is misleading. PR-URL: nodejs#53364 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
Remove the unused ECPointer argument and rename the function since the current name is misleading. PR-URL: #53364 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
Remove the unused ECPointer argument and rename the function since the current name is misleading. PR-URL: #53364 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the unused
ECPointerargument and rename the function since the current name is misleading -- it specifically returns the group size in bits, not a representation of the group.