Skip to content

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented May 6, 2024

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 6, 2024
@mhdawson
Copy link
Member Author

mhdawson commented May 6, 2024

Some related background

@benjamingr
Copy link
Member

@goldbergyoni @lirantal

@mhdawson mhdawson added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label May 7, 2024
@mhdawson
Copy link
Member Author

mhdawson commented May 7, 2024

@kyliewd FYI as the current approach asks for retweets through slack.

@kyliewd
Copy link

kyliewd commented May 7, 2024

thanks @mhdawson - this sounds fine to me. i would add though that as ambassadors for the project, they need to follow CoC guidelines (especially when promoting content)

i'm happy to help promote this as needed

@mhdawson
Copy link
Member Author

@kyliewd thanks for reviewing/confirming.

@mhdawson
Copy link
Member Author

@kyliewd and good point about the CoC, will add some words around that.

@Trott
Copy link
Member

Trott commented May 21, 2024

I won't block over this but: We seem to spin these things up from time to time (Evangelism, Social Media Delegates, Outreach, Node.js Collection, and more) and it seems that they never work out well. I don't see an indication of what is different this time around that makes a more successful initiative likely. Maybe a clear sentence explaining the goal (or mission or vision or whatever) in the document would help mitigate the "Haven't we seen this before?" sense I'm getting. Is this based on a successful initiative in another big project (like Python or Rust) or something like that?

Trott
Trott previously requested changes May 21, 2024
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBD needs to be replaced, right?

@mhdawson
Copy link
Member Author

@Trott since you've indicated you won't block, I assume no response to the comment of "this never works out well". Buy my 2 cents I think this is a much more specific/constrained proposal than some of the instances you pointed to which started as WIP and never went beyond that.

@Trott Trott dismissed their stale review May 22, 2024 17:52

TBD replaced

@mhdawson
Copy link
Member Author

@Trott, I can't find it right now but on the question of calendar year versus 12 months I think calendar year makes more sense. It will be easier to handle all together versus trying to track 12 months for each ambassador.

@Trott

This comment was marked as resolved.

@Trott
Copy link
Member

Trott commented May 30, 2024

Michael let me know that there was a 2-hour discussion about this in February. I can't find any comprehensive notes (just a few bullet points, but also maybe I don't know where to look?--the siloing problem is real!), but there's a video at https://www.youtube.com/live/gTgHkyCyXP0.

So, you know, if anyone else wants a fuller background on where this is coming from, that might help.

@Trott
Copy link
Member

Trott commented May 30, 2024

Michael let me know that there was a 2-hour discussion about this in February. I can't find any comprehensive notes (just a few bullet points, but also maybe I don't know where to look?--the siloing problem is real!), but there's a video at https://www.youtube.com/live/gTgHkyCyXP0.

So, you know, if anyone else wants a fuller background on where this is coming from, that might help.

One surprise for me is that it seems that the goal here is to solve friction/pain points experienced by self-identified advocates for Node.js. That's a separate (but, obviously, related) population from Node.js core and Node.js users. It's a different lens than the one I was looking through.

@mhdawson
Copy link
Member Author

mhdawson commented Jun 6, 2024

@Trott thanks for adding the link to the video, thats probably something I should have included when I opended the PR as providing good context.

Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

I'm not a core collaborator, and these are only suggestions

@mhdawson mhdawson force-pushed the ambassador-program branch from 0afa954 to ff37eb0 Compare June 12, 2024 22:11
@mhdawson
Copy link
Member Author

Squashed, rebased and forced pushed to see if that will fix the Windows failure as I think that job has been temporarily disabled.

@mhdawson
Copy link
Member Author

Plan to land tomorrow assuming CI passes.

mhdawson added a commit that referenced this pull request Jun 13, 2024
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #52857
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@mhdawson
Copy link
Member Author

Landed in 756b397

@mhdawson mhdawson closed this Jun 13, 2024
targos pushed a commit that referenced this pull request Jun 20, 2024
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #52857
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
sophoniie pushed a commit to sophoniie/node that referenced this pull request Jun 20, 2024
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#52857
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#52857
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #52857
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #52857
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. tsc-agenda Issues and PRs to discuss during the meetings of the TSC.

Projects

None yet

Development

Successfully merging this pull request may close these issues.