Skip to content

[v18.x] test, v8: fix wrong import attributes test #52184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[v18.x] test, v8: fix wrong import attributes test #52184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a1e55e
test, v8: fix wrong import attributes test
nicolo-ribaudo Mar 21, 2024
5403648
fixup! test, v8: fix wrong import attributes test
nicolo-ribaudo Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deps/v8/test/mjsunit/harmony/modules-import-assertions-3.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@

// Flags: --harmony-import-assertions

import {life} from 'modules-skip-imports-json-1.mjs';
import {life} from 'modules-skip-imports-json-assert-1.mjs';

assertEquals(42, life());
2 changes: 1 addition & 1 deletion deps/v8/test/mjsunit/harmony/modules-import-assertions-dynamic-5.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// Flags: --allow-natives-syntax --harmony-import-assertions

var life;
import('modules-skip-imports-json-1.mjs',).then(namespace => life = namespace.life());
import('modules-skip-imports-json-assert-1.mjs',).then(namespace => life = namespace.life());

%PerformMicrotaskCheckpoint();

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/test/mjsunit/harmony/modules-import-attributes-3.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@

// Flags: --harmony-import-attributes

import {life} from 'modules-skip-imports-json-1.mjs';
import {life} from 'modules-skip-imports-json-with-1.mjs';

assertEquals(42, life());
2 changes: 1 addition & 1 deletion deps/v8/test/mjsunit/harmony/modules-import-attributes-dynamic-5.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// Flags: --allow-natives-syntax --harmony-import-attributes

var life;
import('modules-skip-imports-json-1.mjs',).then(namespace => life = namespace.life());
import('modules-skip-imports-json-with-1.mjs',).then(namespace => life = namespace.life());

%PerformMicrotaskCheckpoint();

Expand Down
0 ...t/harmony/modules-skip-imports-json-1.mjs → ...ny/modules-skip-imports-json-assert-1.mjs
View file
Open in desktop
File renamed without changes.
6 changes: 6 additions & 0 deletions deps/v8/test/mjsunit/harmony/modules-skip-imports-json-with-1.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// Copyright 2021 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import json from "modules-skip-1.json" with { type: "json" };
export function life() { return json.life; }