Skip to content

esm: improve JSDoc annotation of internal functions #49959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2023
Merged

esm: improve JSDoc annotation of internal functions #49959

merged 2 commits into from
Oct 1, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 29, 2023

Extracted from #49918

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 29, 2023
@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. typings and removed needs-ci PRs that need a full CI run. labels Sep 29, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@GeoffreyBooth

This comment was marked as resolved.

Sign in to view
@GeoffreyBooth GeoffreyBooth mentioned this pull request Oct 1, 2023
Merged
@atlowChemi atlowChemi added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 1, 2023
@aduh95 aduh95 removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 1, 2023
@aduh95 aduh95 merged commit aadfea4 into nodejs:main Oct 1, 2023
@aduh95
Copy link
Contributor Author

aduh95 commented Oct 1, 2023

Landed in aadfea4

@aduh95 aduh95 deleted the run-main-typings branch October 1, 2023 07:27
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@aduh95 @GeoffreyBooth @alexfernandez
esm: improve JSDoc annotation of internal functions
ed6b515 
Co-authored-by: Geoffrey Booth <[email protected]>
PR-URL: nodejs#49959
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95 @GeoffreyBooth @targos
esm: improve JSDoc annotation of internal functions
20c050a 
Co-authored-by: Geoffrey Booth <[email protected]>
PR-URL: nodejs#49959
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95 @GeoffreyBooth @targos
esm: improve JSDoc annotation of internal functions
acba7c4 
Co-authored-by: Geoffrey Booth <[email protected]>
PR-URL: nodejs#49959
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@targos targos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 11, 2023
@aduh95 @GeoffreyBooth @targos
esm: improve JSDoc annotation of internal functions
112cc7f 
Co-authored-by: Geoffrey Booth <[email protected]>
PR-URL: #49959
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95 @GeoffreyBooth @targos
esm: improve JSDoc annotation of internal functions
2f26771 
Co-authored-by: Geoffrey Booth <[email protected]>
PR-URL: nodejs#49959
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95 @GeoffreyBooth @targos
esm: improve JSDoc annotation of internal functions
72644d6 
Co-authored-by: Geoffrey Booth <[email protected]>
PR-URL: #49959
Backport-PR-URL: #50669
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@aduh95 @GeoffreyBooth @debadree25
esm: improve JSDoc annotation of internal functions
739f0ab 
Co-authored-by: Geoffrey Booth <[email protected]>
PR-URL: nodejs#49959
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher @GeoffreyBooth
esm: improve JSDoc annotation of internal functions
27bdb12 
Co-authored-by: Geoffrey Booth <[email protected]>
PR-URL: nodejs/node#49959
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher @GeoffreyBooth
esm: improve JSDoc annotation of internal functions
d6eb22c 
Co-authored-by: Geoffrey Booth <[email protected]>
PR-URL: nodejs/node#49959
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land. typings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95 @nodejs-github-bot @GeoffreyBooth @atlowChemi @targos