Skip to content

node-api: treat V8 platform symbols same as base #49740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

node-api: treat V8 platform symbols same as base #49740

wants to merge 2 commits into from

Conversation

sparist
Copy link

@sparist sparist commented Sep 20, 2023

Export V8 platform symbols in the Node shared library build, in the same way as with V8 base, to allow linking on Windows.

PR-URL: #49596

@sparist
node-api: treat V8 platform symbols same as base
bdc361f 
Export V8 platform symbols in the Node shared library build,
in the same way as with V8 base, to allow linking on Windows.

PR-URL: nodejs#49596
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Sep 20, 2023
@sparist sparist mentioned this pull request Sep 20, 2023
Closed
@sparist
Copy link
Author

sparist commented Sep 20, 2023

This PR replaces #49596.

@bnoordhuis bnoordhuis added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Sep 21, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54108/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5576/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5576/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5576/

This was referenced Sep 22, 2023
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54223/

mhdawson
mhdawson approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot mentioned this pull request Sep 27, 2023
Open
21 tasks
@aduh95
Copy link
Contributor

aduh95 commented May 11, 2024

Can you please rebase on top of main?

@aduh95 aduh95 added the stalled Issues and PRs that are stalled. label May 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

@sparist
Copy link
Author

sparist commented May 16, 2024

I believe the changes have now been rebased onto main

@github-actions github-actions bot removed the stalled Issues and PRs that are stalled. label Mar 27, 2025
@bjohansebas bjohansebas added the request-ci Add this label to start a Jenkins CI on a PR. label May 24, 2025
@bjohansebas
Copy link
Member

@nodejs/v8 @nodejs/gyp Any reason why this hasn’t been merged? It has approvals. I’m going to run the CI again since the PR is a bit old.

@bjohansebas bjohansebas mentioned this pull request May 24, 2025
Open
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 24, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67041/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees

No one assigned

Labels

tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sparist @nodejs-github-bot @aduh95 @bjohansebas @bnoordhuis @jasnell @mhdawson