Skip to content

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented May 8, 2023

This is an automated update of ada to 2.4.0.

Fixes #47894

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label May 8, 2023
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented May 8, 2023

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 8, 2023
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels May 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Fast-track has been requested by @anonrig. Please 👍 to approve.

@anonrig
Copy link
Member

anonrig commented May 8, 2023

cc @RaisinTen @bnoordhuis @tniessen

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Copy link
Member

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2023
@nodejs-github-bot nodejs-github-bot merged commit a6ad5d8 into main May 9, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Landed in a6ad5d8

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-ada branch May 9, 2023 15:53
targos pushed a commit that referenced this pull request May 12, 2023
PR-URL: #47922
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 5, 2023
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 5, 2023
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 5, 2023
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 17, 2023
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 23, 2023
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 24, 2023
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 24, 2023
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 26, 2023
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 26, 2023
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 9, 2023
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 9, 2023
PR-URL: nodejs#47922
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
PR-URL: #47922
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ada's license

6 participants