Skip to content

sea: use JSON configuration and blob content for SEA #47125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 9, 2023
Merged

sea: use JSON configuration and blob content for SEA #47125

merged 5 commits into from
Apr 9, 2023

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Mar 16, 2023 •
edited
Loading

This implements the ideas discussed in nodejs/single-executable#58. This changes the SEA contract in that:

  1. The data injected is now a blob whose layout is controlled by us (generated with --experimental-sea-config), this makes it possible to include other resources into the SEA other than just the JS code
  2. The configuration is now JSON-based (accepted by --experimental-sea-config) which allows for more flexibility.

Refs: nodejs/single-executable#58

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/single-executable
  • @nodejs/startup
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 16, 2023
anonrig
anonrig reviewed Mar 16, 2023
View reviewed changes
RaisinTen
RaisinTen reviewed Mar 17, 2023
View reviewed changes
addaleax
addaleax reviewed Mar 17, 2023
View reviewed changes
@joyeecheung joyeecheung force-pushed the sea-blob branch 2 times, most recently from 0f67d94 to c43ae7c Compare March 28, 2023 19:58
@joyeecheung
Copy link
Member Author

Updated the documentation a bit, still needs to write a bunch of tests...

@joyeecheung joyeecheung force-pushed the sea-blob branch 4 times, most recently from 8654fbd to 807b866 Compare April 4, 2023 17:09
@joyeecheung joyeecheung changed the title POC: use JSON configuration and blob content for SEA src: use JSON configuration and blob content for SEA Apr 4, 2023
@joyeecheung joyeecheung changed the title src: use JSON configuration and blob content for SEA sea: use JSON configuration and blob content for SEA Apr 4, 2023
@joyeecheung joyeecheung marked this pull request as ready for review April 4, 2023 17:12
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50925/

@joyeecheung
Copy link
Member Author

Added tests and documentation. @nodejs/single-executable PTAL thanks!

@github-actions github-actions bot mentioned this pull request Apr 5, 2023
Open
26 tasks
tony-go
tony-go reviewed Apr 5, 2023
View reviewed changes
Copy link
Member

@tony-go tony-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼 Awesome

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50960/

RaisinTen
RaisinTen reviewed Apr 5, 2023
View reviewed changes
RaisinTen
RaisinTen reviewed Apr 6, 2023
View reviewed changes
@joyeecheung joyeecheung added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 9, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 9, 2023
@nodejs-github-bot nodejs-github-bot merged commit 491a5c9 into nodejs:main Apr 9, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 491a5c9

@RafaelGSS RafaelGSS mentioned this pull request Apr 11, 2023
Merged
@github-actions github-actions bot mentioned this pull request Apr 12, 2023
Open
31 tasks
@RaisinTen
Copy link
Member

@joyeecheung should this be labelled as a notable-change PRs with changes that should be highlighted in changelogs. because this changes how this feature is supposed to be used?

@joyeecheung joyeecheung added the notable-change PRs with changes that should be highlighted in changelogs. label Apr 12, 2023
@github-actions
Copy link
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @joyeecheung.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment.

@joyeecheung
Copy link
Member Author

Good idea. Done.

@RaisinTen
Copy link
Member

FYI @joyeecheung:

Originally posted by @RafaelGSS in #47381 (comment)

I'll include both in the "Other notable changes" section. In case you feel it should be placed in the same section as V8/Permission Model changes, update the PR (#47125 and #47233) description according to the bot request.

Should we add some release notes for this change?

@RaisinTen RaisinTen added the single-executable Issues and PRs related to single-executable applications label May 5, 2023
This was referenced Jul 3, 2023
Merged
Closed
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax left review comments

@anonrig anonrig anonrig left review comments

@RaisinTen RaisinTen RaisinTen approved these changes

+1 more reviewer

@tony-go tony-go tony-go approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. single-executable Issues and PRs related to single-executable applications

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@joyeecheung @nodejs-github-bot @RaisinTen @addaleax @anonrig @tony-go @danielleadams