Skip to content

Conversation

tlhunter
Copy link
Contributor

@tlhunter tlhunter commented Mar 6, 2023

  • the diagnostics_channel module was backported to Node.js v14.17.0

@nodejs-github-bot nodejs-github-bot added diagnostics_channel Issues and PRs related to diagnostics channel doc Issues and PRs related to the documentations. labels Mar 6, 2023
@tlhunter tlhunter force-pushed the patch-2 branch 3 times, most recently from f17a68c to 83d3f06 Compare March 6, 2023 23:18
`node:diagnostics_channel` was backported to Node.js v14.17.0.
@lpinca lpinca added fast-track PRs that do not need to wait for 48 hours to land. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Fast-track has been requested by @lpinca. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 7, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/46984
✔  Done loading data for nodejs/node/pull/46984
----------------------------------- PR info ------------------------------------
Title      doc: diagnostics_channel added in v14.17.0 (#46984)
Author     Thomas Hunter II  (@tlhunter)
Branch     tlhunter:patch-2 -> nodejs:main
Labels     doc, fast-track, diagnostics_channel
Commits    1
 - doc: fix history information for `node:diagnostics_channel`
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/46984
Reviewed-By: Stephen Belanger 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46984
Reviewed-By: Stephen Belanger 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 06 Mar 2023 22:59:57 GMT
   ✔  Approvals: 4
   ✔  - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/46984#pullrequestreview-1327381744
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46984#pullrequestreview-1327491048
   ✔  - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/46984#pullrequestreview-1327714426
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46984#pullrequestreview-1329456433
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least one collaborator's approval (👍).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4358230515

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Mar 7, 2023
@Flarna Flarna added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 8, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 8, 2023
@nodejs-github-bot nodejs-github-bot merged commit 8b02df9 into nodejs:main Mar 8, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 8b02df9

@tlhunter tlhunter deleted the patch-2 branch March 9, 2023 03:33
targos pushed a commit that referenced this pull request Mar 13, 2023
`node:diagnostics_channel` was backported to Node.js v14.17.0.

PR-URL: #46984
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
targos pushed a commit that referenced this pull request Mar 14, 2023
`node:diagnostics_channel` was backported to Node.js v14.17.0.

PR-URL: #46984
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
`node:diagnostics_channel` was backported to Node.js v14.17.0.

PR-URL: #46984
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-failed An error occurred while landing this pull request using GitHub Actions. diagnostics_channel Issues and PRs related to diagnostics channel doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants